You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "7ossam7atem1 (via GitHub)" <gi...@apache.org> on 2025/02/28 14:32:16 UTC
[PR] FINERACT-2081: Improve DateFormat class code quality [fineract]
7ossam7atem1 opened a new pull request, #4395:
URL: https://github.com/apache/fineract/pull/4395
## Description
- Added constant `INVALID_DATE_FORMAT_MESSAGE` for the repeated string
- Removed unused formatter variable
- Added `@Getter` Lombok annotation at class level
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Improve DateFormat class code quality [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4395:
URL: https://github.com/apache/fineract/pull/4395#issuecomment-2693207781
@7ossam7atem1 I think that other strings can be improved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Improve DateFormat class code quality [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #4395:
URL: https://github.com/apache/fineract/pull/4395#issuecomment-2694866802
@7ossam7atem1 FINERACT-2081 was a story to cover minor changes in 1.11. Since this version of release process started, we cannot use this story anymore. Kindly use the https://issues.apache.org/jira/browse/FINERACT-2181 from now on for minor changes which will be part of 1.12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Improve DateFormat class code quality [fineract]
Posted by "7ossam7atem1 (via GitHub)" <gi...@apache.org>.
7ossam7atem1 closed pull request #4395: FINERACT-2081: Improve DateFormat class code quality
URL: https://github.com/apache/fineract/pull/4395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Improve DateFormat class code quality [fineract]
Posted by "7ossam7atem1 (via GitHub)" <gi...@apache.org>.
7ossam7atem1 commented on PR #4395:
URL: https://github.com/apache/fineract/pull/4395#issuecomment-2693679860
> @7ossam7atem1 I think that other strings can be improved
@IOhacker Done , Waiting for your review :")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Improve DateFormat class code quality [fineract]
Posted by "7ossam7atem1 (via GitHub)" <gi...@apache.org>.
7ossam7atem1 commented on PR #4395:
URL: https://github.com/apache/fineract/pull/4395#issuecomment-2695093742
> @7ossam7atem1 [FINERACT-2081](https://issues.apache.org/jira/browse/FINERACT-2081) was a story to cover minor changes in 1.11. Since this version of release process started, we cannot use this story anymore. Kindly use the https://issues.apache.org/jira/browse/FINERACT-2181 from now on for minor changes which will be part of 1.12.
@adamsaghy Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org