You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Cerdore (via GitHub)" <gi...@apache.org> on 2024/01/25 12:29:25 UTC
[PR] GH-39765: [C++] Fix failures in dataset-scanner-benchmark [arrow]
Cerdore opened a new pull request, #39794:
URL: https://github.com/apache/arrow/pull/39794
### Rationale for this change
`ScanOnlyBench` use 2 kind of options to scan, but ignore the function `MakeScanNode` will return 4 extra columns.
### What changes are included in this PR?
Change the expected result of bench `ScanOnlyBench`
### Are these changes tested?
They covered by existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39765: [C++][Dataset] Fix failures in dataset-scanner-benchmark [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #39794:
URL: https://github.com/apache/arrow/pull/39794#discussion_r1466309675
##########
cpp/src/arrow/dataset/scanner_benchmark.cc:
##########
@@ -162,7 +162,11 @@ void ScanOnly(
acero::DeclarationToTable(std::move(scan)));
ASSERT_GT(collected->num_rows(), 0);
- ASSERT_EQ(collected->num_columns(), 2);
+ if (factory_name == "scan") {
+ ASSERT_EQ(collected->num_columns(), 6);
Review Comment:
(Seems this need a more `clang-format`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39765: [C++][Dataset] Fix failures in dataset-scanner-benchmark [arrow]
Posted by "Cerdore (via GitHub)" <gi...@apache.org>.
Cerdore commented on code in PR #39794:
URL: https://github.com/apache/arrow/pull/39794#discussion_r1466355207
##########
cpp/src/arrow/dataset/scanner_benchmark.cc:
##########
@@ -162,7 +162,11 @@ void ScanOnly(
acero::DeclarationToTable(std::move(scan)));
ASSERT_GT(collected->num_rows(), 0);
- ASSERT_EQ(collected->num_columns(), 2);
+ if (factory_name == "scan") {
+ ASSERT_EQ(collected->num_columns(), 6);
Review Comment:
Thanks! Solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39765: [C++][Dataset] Fix failures in dataset-scanner-benchmark [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #39794:
URL: https://github.com/apache/arrow/pull/39794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39765: [C++][Dataset] Fix failures in dataset-scanner-benchmark [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39794:
URL: https://github.com/apache/arrow/pull/39794#issuecomment-1911073301
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9c0a7617d953a74abaec5c14318bc2f46d0d176a.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20879543719) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org