You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Antoine Levy Lambert <an...@gmx.de> on 2015/11/01 19:29:16 UTC
Re: Need feedback for Bugzilla 58555
Hello Stefan,
I have had a look at the code. Is the bit of code which is responsible for the behavior described in Bugzilla 58555 this one :
in org.apache.tools.ant.taskdefs.Execute :
public void setWorkingDirectory(File wd) {
workingDirectory =
(wd == null || wd.getAbsolutePath().equals(antWorkingDirectory))
? null : wd;
}
Would your change essentially be to simplify this setter to
public void setWorkingDirectory(File wd) {
workingDirectory = wd;
}
?
Regards,
Antoine
On Oct 27, 2015, at 2:29 PM, Stefan Bodewig <bo...@apache.org> wrote:
> Hi all
>
> <https://bz.apache.org/bugzilla/show_bug.cgi?id=58555>
>
> I'd rather not repeat what I've typed there. The tldr version: <exec>
> without dir defaults to executing in the current directory if
> vmlauncher="true" and the project's basedir if vmlauncher="false" - and
> has done so ever since we introduced vmlauncher back in Ant 1.4.
>
> I think we can fix the immediate problem of the bug report (dir is
> ignored if it happens to be the CWD) but don't dare to change the split
> logic WRT no dir attribute at all. I'm afraid there will be build files
> that rely on either behavior, so the best we can likely do, is to
> document the difference.
>
> Am I overlooking anything?
>
> Stefan
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Need feedback for Bugzilla 58555
Posted by Stefan Bodewig <bo...@apache.org>.
On 2015-11-01, Antoine Levy Lambert wrote:
> Hello Stefan,
> I have had a look at the code. Is the bit of code which is responsible for the behavior described in Bugzilla 58555 this one :
> in org.apache.tools.ant.taskdefs.Execute :
> public void setWorkingDirectory(File wd) {
> workingDirectory =
> (wd == null || wd.getAbsolutePath().equals(antWorkingDirectory))
> ? null : wd;
> }
> Would your change essentially be to simplify this setter to
> public void setWorkingDirectory(File wd) {
> workingDirectory = wd;
> }
> ?
Right, that's what I'd do.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org