You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cocoon.apache.org by Pasha Minallah <pa...@neptuneinc.org> on 2006/01/04 18:27:52 UTC

Problem with XIncludes in 2.1.8

A bug seems to have been introduced in XIncludes in going from 2.1.7 to 2.1.8.

They seem fine when used in this form:

        <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" parse="xml"
        href="{$common-content-folder}/banner.xml"/>

But there is a problem when used in this form:

    <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" parse="xml"
    href="{$current-content-folder}/banner.xml">
      <xi:fallback>
        <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" parse="xml"
        href="{$common-content-folder}/banner.xml"/>
      </xi:fallback>
    </xi:include>

When used in the latter form, there appears a residual </xi:include> tag in 
the produced XML without a corresponding <xi:include> start tag.  As a 
result, the output XML is not well-formed and has caused us some serious 
problems.  So, we can't upgrade to 2.1.8 until this is fixed.

Has anyone else encountered this problem or is it just me?

Thanks.

-- 
Pasha Minallah
Software Engineer
Neptune and Company, Inc.
http://www.neptuneandco.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
For additional commands, e-mail: users-help@cocoon.apache.org

Re: Problem with XIncludes in 2.1.8

Posted by Joerg Heinicke <jo...@gmx.de>.
On 04.01.2006 20:30, Pasha Minallah wrote:

>>This looks very similar to
>>http://issues.apache.org/jira/secure/ViewIssue.jspa?key=COCOON-1489 which
>>was supposedly checked in for 2.1.8.  Perhaps that patch fixed one
>>situation but broke another?
> 
> This is the same issue as in the link.  The website seems to indicate that the 
> patch was applied to the 2.2-dev branch and not necessarily to 2.1.8.

The patch has been applied:
http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/transformation/XIncludeTransformer.java?rev=160282&r1=153376&r2=160282

Jörg

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
For additional commands, e-mail: users-help@cocoon.apache.org

Re: Problem with XIncludes in 2.1.8

Posted by Antonio Gallardo <ag...@agssa.net>.
Jason Johnston wrote:

>>On Wednesday 04 January 2006 11:48, Jason Johnston wrote:
>>    
>>
>>>This looks very similar to
>>>http://issues.apache.org/jira/secure/ViewIssue.jspa?key=COCOON-1489
>>>which
>>>was supposedly checked in for 2.1.8.  Perhaps that patch fixed one
>>>situation but broke another?
>>>      
>>>
>>This is the same issue as in the link.  The website seems to indicate that
>>the
>>patch was applied to the 2.2-dev branch and not necessarily to 2.1.8.
>>    
>>
>
>It was applied to the 2.1 branch because I found the bug # in the first
>place by browsing the SVN log for the branch.
>
>At first glance it looks to be the same issue but it may be slightly
>different, as the sample in the bug report does not have a xi:include
>within the fallback as your example did.  I'm not saying this is for sure
>the case but that difference may be significant.  Just a possibility that
>should not be discounted.
>  
>
Yep. I reopened the bug.

Best Regards,

Antonio Gallardo.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
For additional commands, e-mail: users-help@cocoon.apache.org

Re: Problem with XIncludes in 2.1.8

Posted by Jason Johnston <co...@lojjic.net>.
> On Wednesday 04 January 2006 11:48, Jason Johnston wrote:
>>
>> This looks very similar to
>> http://issues.apache.org/jira/secure/ViewIssue.jspa?key=COCOON-1489
>> which
>> was supposedly checked in for 2.1.8.  Perhaps that patch fixed one
>> situation but broke another?
>
> This is the same issue as in the link.  The website seems to indicate that
> the
> patch was applied to the 2.2-dev branch and not necessarily to 2.1.8.

It was applied to the 2.1 branch because I found the bug # in the first
place by browsing the SVN log for the branch.

At first glance it looks to be the same issue but it may be slightly
different, as the sample in the bug report does not have a xi:include
within the fallback as your example did.  I'm not saying this is for sure
the case but that difference may be significant.  Just a possibility that
should not be discounted.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
For additional commands, e-mail: users-help@cocoon.apache.org

Re: Problem with XIncludes in 2.1.8

Posted by Pasha Minallah <pa...@neptuneinc.org>.
On Wednesday 04 January 2006 11:48, Jason Johnston wrote:
>
> This looks very similar to
> http://issues.apache.org/jira/secure/ViewIssue.jspa?key=COCOON-1489 which
> was supposedly checked in for 2.1.8.  Perhaps that patch fixed one
> situation but broke another?

This is the same issue as in the link.  The website seems to indicate that the 
patch was applied to the 2.2-dev branch and not necessarily to 2.1.8.

-- 
Pasha Minallah
Software Engineer
Neptune and Company, Inc.
http://www.neptuneandco.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
For additional commands, e-mail: users-help@cocoon.apache.org

Re: Problem with XIncludes in 2.1.8

Posted by Jason Johnston <co...@lojjic.net>.
This looks very similar to
http://issues.apache.org/jira/secure/ViewIssue.jspa?key=COCOON-1489 which
was supposedly checked in for 2.1.8.  Perhaps that patch fixed one
situation but broke another?

> A bug seems to have been introduced in XIncludes in going from 2.1.7 to
> 2.1.8.
>
> They seem fine when used in this form:
>
>         <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" parse="xml"
>         href="{$common-content-folder}/banner.xml"/>
>
> But there is a problem when used in this form:
>
>     <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" parse="xml"
>     href="{$current-content-folder}/banner.xml">
>       <xi:fallback>
>         <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" parse="xml"
>         href="{$common-content-folder}/banner.xml"/>
>       </xi:fallback>
>     </xi:include>
>
> When used in the latter form, there appears a residual </xi:include> tag
> in
> the produced XML without a corresponding <xi:include> start tag.  As a
> result, the output XML is not well-formed and has caused us some serious
> problems.  So, we can't upgrade to 2.1.8 until this is fixed.
>
> Has anyone else encountered this problem or is it just me?
>
> Thanks.
>
> --
> Pasha Minallah
> Software Engineer
> Neptune and Company, Inc.
> http://www.neptuneandco.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
> For additional commands, e-mail: users-help@cocoon.apache.org
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
For additional commands, e-mail: users-help@cocoon.apache.org