[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2707: ARTEMIS-2002 Proton transport objects leaked if client disconnects abruptly

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #2707: ARTEMIS-2002 Proton transport objects leaked if client disconnects abruptly
URL: https://github.com/apache/activemq-artemis/pull/2707#discussion_r294611471
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
 ##########
 @@ -183,6 +188,11 @@ public void flush() {
    }
 
    public void close(ErrorCondition errorCondition) {
+      if (scheduledPool != null && scheduledPool instanceof ThreadPoolExecutor &&
 
 Review comment:
   You can call cancel on the future to let the pool remote it and it would be better (just for likelihood with other similar declarations) to use the wildcard typed version of it or ScheduledFuture<?>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services