You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Ajit Kumar <aj...@hortonworks.com> on 2016/02/23 22:58:28 UTC

Review Request 43909: Remove Result.STATUS enum as it is not being used

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43909/
-----------------------------------------------------------

Review request for Ambari and Nahappan Somasundaram.


Bugs: AMBARI-15149
    https://issues.apache.org/jira/browse/AMBARI-15149


Repository: ambari


Description
-------

Remove Result.STATUS enum as it is not being used


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java c827ac49ea204c25065e84ffbe4395a720a8dba9 

Diff: https://reviews.apache.org/r/43909/diff/


Testing
-------


Thanks,

Ajit Kumar


Re: Review Request 43909: Remove Result.STATUS enum as it is not being used

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43909/#review120539
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 24, 2016, 4:58 p.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43909/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 4:58 p.m.)
> 
> 
> Review request for Ambari and Nahappan Somasundaram.
> 
> 
> Bugs: AMBARI-15149
>     https://issues.apache.org/jira/browse/AMBARI-15149
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove Result.STATUS enum as it is not being used
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java c827ac49ea204c25065e84ffbe4395a720a8dba9 
> 
> Diff: https://reviews.apache.org/r/43909/diff/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/job/Ambari-trunk-test-patch/5525/consoleFull
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [  4.895 s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [  0.061 s]
> [INFO] Ambari Web ........................................ SUCCESS [ 12.744 s]
> [INFO] Ambari Views ...................................... SUCCESS [  1.461 s]
> [INFO] Ambari Admin View ................................. SUCCESS [ 10.410 s]
> [INFO] ambari-metrics .................................... SUCCESS [  0.253 s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [  0.561 s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [  1.324 s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [  0.798 s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [  0.912 s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [  3.370 s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [  8.213 s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [  0.632 s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [  2.007 s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [01:14 min]
> [INFO] Ambari Server ..................................... SUCCESS [02:53 min]
> [INFO] Ambari Functional Tests ........................... SUCCESS [  0.890 s]
> [INFO] Ambari Agent ...................................... SUCCESS [ 19.325 s]
> [INFO] Ambari Client ..................................... SUCCESS [  0.040 s]
> [INFO] Ambari Python Client .............................. SUCCESS [  0.450 s]
> [INFO] Ambari Groovy Client .............................. SKIPPED
> [INFO] Ambari Shell ...................................... SKIPPED
> [INFO] Ambari Python Shell ............................... SKIPPED
> [INFO] Ambari Groovy Shell ............................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 05:22 min
> [INFO] Finished at: 2016-02-24T02:18:10+00:00
> [INFO] Final Memory: 138M/868M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>


Re: Review Request 43909: Remove Result.STATUS enum as it is not being used

Posted by Ajit Kumar <aj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43909/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 4:58 p.m.)


Review request for Ambari and Nahappan Somasundaram.


Bugs: AMBARI-15149
    https://issues.apache.org/jira/browse/AMBARI-15149


Repository: ambari


Description
-------

Remove Result.STATUS enum as it is not being used


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java c827ac49ea204c25065e84ffbe4395a720a8dba9 

Diff: https://reviews.apache.org/r/43909/diff/


Testing (updated)
-------

https://builds.apache.org/job/Ambari-trunk-test-patch/5525/consoleFull

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [  4.895 s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [  0.061 s]
[INFO] Ambari Web ........................................ SUCCESS [ 12.744 s]
[INFO] Ambari Views ...................................... SUCCESS [  1.461 s]
[INFO] Ambari Admin View ................................. SUCCESS [ 10.410 s]
[INFO] ambari-metrics .................................... SUCCESS [  0.253 s]
[INFO] Ambari Metrics Common ............................. SUCCESS [  0.561 s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [  1.324 s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [  0.798 s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [  0.912 s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [  3.370 s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [  8.213 s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [  0.632 s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [  2.007 s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [01:14 min]
[INFO] Ambari Server ..................................... SUCCESS [02:53 min]
[INFO] Ambari Functional Tests ........................... SUCCESS [  0.890 s]
[INFO] Ambari Agent ...................................... SUCCESS [ 19.325 s]
[INFO] Ambari Client ..................................... SUCCESS [  0.040 s]
[INFO] Ambari Python Client .............................. SUCCESS [  0.450 s]
[INFO] Ambari Groovy Client .............................. SKIPPED
[INFO] Ambari Shell ...................................... SKIPPED
[INFO] Ambari Python Shell ............................... SKIPPED
[INFO] Ambari Groovy Shell ............................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:22 min
[INFO] Finished at: 2016-02-24T02:18:10+00:00
[INFO] Final Memory: 138M/868M
[INFO] ------------------------------------------------------------------------


Thanks,

Ajit Kumar


Re: Review Request 43909: Remove Result.STATUS enum as it is not being used

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43909/#review120397
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java 
<https://reviews.apache.org/r/43909/#comment181835>

    I see we use ResultStatus instead.
    Good find.


- Alejandro Fernandez


On Feb. 23, 2016, 9:58 p.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43909/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 9:58 p.m.)
> 
> 
> Review request for Ambari and Nahappan Somasundaram.
> 
> 
> Bugs: AMBARI-15149
>     https://issues.apache.org/jira/browse/AMBARI-15149
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove Result.STATUS enum as it is not being used
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java c827ac49ea204c25065e84ffbe4395a720a8dba9 
> 
> Diff: https://reviews.apache.org/r/43909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>


Re: Review Request 43909: Remove Result.STATUS enum as it is not being used

Posted by Nahappan Somasundaram <ns...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43909/#review120399
-----------------------------------------------------------


Ship it!




Ship It!

- Nahappan Somasundaram


On Feb. 23, 2016, 1:58 p.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43909/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 1:58 p.m.)
> 
> 
> Review request for Ambari and Nahappan Somasundaram.
> 
> 
> Bugs: AMBARI-15149
>     https://issues.apache.org/jira/browse/AMBARI-15149
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove Result.STATUS enum as it is not being used
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java c827ac49ea204c25065e84ffbe4395a720a8dba9 
> 
> Diff: https://reviews.apache.org/r/43909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>


Re: Review Request 43909: Remove Result.STATUS enum as it is not being used

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43909/#review120392
-----------------------------------------------------------


Ship it!




Interesting.

- Sumit Mohanty


On Feb. 23, 2016, 9:58 p.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43909/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 9:58 p.m.)
> 
> 
> Review request for Ambari and Nahappan Somasundaram.
> 
> 
> Bugs: AMBARI-15149
>     https://issues.apache.org/jira/browse/AMBARI-15149
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove Result.STATUS enum as it is not being used
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java c827ac49ea204c25065e84ffbe4395a720a8dba9 
> 
> Diff: https://reviews.apache.org/r/43909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>