You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/02/19 05:16:03 UTC
Review Request 43754: WIP: Enhance allocator performance.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43754/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-3283
https://issues.apache.org/jira/browse/MESOS-3283
Repository: mesos
Description
-------
Enhance allocator performance.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp a9d2c23162892e22220f97d89a076d2311091d91
src/master/allocator/sorter/drf/sorter.hpp 4669149b81de39b4bb921ef7cd6787aa583f6e40
src/master/allocator/sorter/drf/sorter.cpp 18797e42a9c2bd20392020237cfae600a5ffe12c
src/master/allocator/sorter/sorter.hpp a0a779b81f6d048271f15256b38ff907ae144b83
Diff: https://reviews.apache.org/r/43754/diff/
Testing
-------
./src/mesos-tests --benchmark --gtest_filter=SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
**Before this patches:**
```
[ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
Using 10000 slaves and 100 frameworks
Added 100 frameworks in 1203us
Added 10000 slaves in 25.604792secs
Updated 10000 slaves in 27.777452secs
[ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14 (54386 ms)
```
**After this patches:**
```
[ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
Using 10000 slaves and 100 frameworks
Added 100 frameworks in 1846us
Added 10000 slaves in 4.953045secs
Updated 10000 slaves in 4.338845secs
[ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14 (10309 ms)
```
Thanks,
Klaus Ma
Re: Review Request 43754: WIP: Enhance allocator performance.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43754/#review119853
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43754]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 19, 2016, 4:16 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43754/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 4:16 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3283
> https://issues.apache.org/jira/browse/MESOS-3283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enhance allocator performance.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp a9d2c23162892e22220f97d89a076d2311091d91
> src/master/allocator/sorter/drf/sorter.hpp 4669149b81de39b4bb921ef7cd6787aa583f6e40
> src/master/allocator/sorter/drf/sorter.cpp 18797e42a9c2bd20392020237cfae600a5ffe12c
> src/master/allocator/sorter/sorter.hpp a0a779b81f6d048271f15256b38ff907ae144b83
>
> Diff: https://reviews.apache.org/r/43754/diff/
>
>
> Testing
> -------
>
> ./src/mesos-tests --benchmark --gtest_filter=SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
>
> **Before this patches:**
>
> ```
> [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
> Using 10000 slaves and 100 frameworks
> Added 100 frameworks in 1203us
> Added 10000 slaves in 25.604792secs
> Updated 10000 slaves in 27.777452secs
> [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14 (54386 ms)
> ```
>
> **After this patches:**
>
> ```
> [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
> Using 10000 slaves and 100 frameworks
> Added 100 frameworks in 1846us
> Added 10000 slaves in 4.953045secs
> Updated 10000 slaves in 4.338845secs
> [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14 (10309 ms)
> ```
>
>
> Thanks,
>
> Klaus Ma
>
>