You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/12/13 20:30:16 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1238
CLOUDSTACK-9160: Remove unused folder(s)/file(s); engine/api/src/org/…
…apache/engine/subsystem/api/storage/disktype
Empty files. Moved DiskFormat.java to engine/api/src/org/apache/engine/subsystem/api/storage/type
As a developer I want
- a clean project to work on
- a project with maintained code
- a project without dead code or files
Builds ok:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:04.428s (Wall Clock)
[INFO] Finished at: Sun Dec 13 20:25:49 CET 2015
[INFO] Final Memory: 95M/787M
[INFO] ------------------------------------------------------------------------
```
Ping @wido @DaanHoogland @remibergsma @miguelaferreira @wilderrodrigues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9160
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1238
----
commit f47e11b6dcf31d0c4973d37d71acd9847edd9f4d
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-12-13T19:27:02Z
CLOUDSTACK-9160: Remove unused folder(s)/file(s); engine/api/src/org/apache/engine/subsystem/api/storage/disktype
Empty files. Moved DiskFormat.java to engine/api/src/org/apache/engine/subsystem/api/storage/type
As a developer I want
- a clean project to work on
- a project with maintained code
- a project without dead code or files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-172384379
LGTM based on the files, no tests were made.
What is happening with Jenkins? I noticed that many PRs are flagged with error because Jenkins did not work.
I saw in an email before that communication seems poor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-171251445
@borisroman can you post any results if you have them? If you care you can force push to have jenkins validate the PR but as far as I can see no added value to a local build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-171046691
Nice @borisroman, can you send it to test it again?
It seems that Jenkins is not working...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-173186580
Closing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-171215623
LGTM , I'll look at jenkins again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---