You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/17 23:30:18 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #3628: Add Support for Gradle Configuration Cache
lkishalmi opened a new pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628
This one is depends on #3620 (that's the first commit in this PR) will be rebased when #3620 is mainlined.
Till then the 2nd commit allows users to use the Gradle Configuration Cache feature which is in incubation phase.
That required the ```nb-toolig.gradle``` init script modified not to read the System properties for the NetBeans tooling jar file, so that file is used as a template and NB create a one in the cache dir using the absolute location of the tooling jar.
As this feature is somewhat new, the default setting is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3628: Add Support for Gradle Configuration Cache
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628#issuecomment-1046555771
The cached processed init script will not work as expected if:
- another installation of NB will use the same userdir, especially when a different NB version does so.
- NB installation is moved to another directory
- Gradle module upgrades w/ changed gradle tooling
I would suggest to still read either system property or pass the location as project property. Other scenarios seem more complicated - i.e. incorporate location + tooling .jar + init script digest hash into the cached filename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3628: Add Support for Gradle Configuration Cache
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628#issuecomment-1048605942
> Well, the init script is in the cache dir not in the user dir, so it should not considered to be shareable by different instances.
Note that if you pass `--user-directory` (but without an explicit `--cachedir` to NetBeans (and I do, as I maintain several sets of configs for several projects), then the cache dir is AFAIK placed in `$userdir/var/cache`; at least on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #3628: Add Support for Gradle Configuration Cache
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628#issuecomment-1048605942
> Well, the init script is in the cache dir not in the user dir, so it should not considered to be shareable by different instances.
Note that if you pass `--user-directory` (but without an explicit `--cachedir` to NetBeans (and I do, as I maintain several sets of configs for several projects), then the cache dir is AFAIK placed in `$userdir/var/cache`; at least on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #3628: Add Support for Gradle Configuration Cache
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #3628: Add Support for Gradle Configuration Cache
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628#issuecomment-1046555771
The cached processed init script will not work as expected if:
- another installation of NB will use the same userdir, especially when a different NB version does so.
- NB installation is moved to another directory
- Gradle module upgrades w/ changed gradle tooling
I would suggest to still read either system property or pass the location as project property. Other scenarios seem more complicated - i.e. incorporate location + tooling .jar + init script digest hash into the cached filename. Or maybe refresh the initscript before each build .... + some precaution if more builds are executed in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3628: Add Support for Gradle Configuration Cache
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628#issuecomment-1047225938
Well, the init script is in the cache dir not in the user dir, so it should not considered to be shareable by different instances. Though changed the code to generate the script on the first call/classloader instance so it should work even with runtime module upgrades as well.
If it's possible I'd try to avoid passing extra properties and things to a build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #3628: Add Support for Gradle Configuration Cache
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #3628:
URL: https://github.com/apache/netbeans/pull/3628#issuecomment-1048605942
> Well, the init script is in the cache dir not in the user dir, so it should not considered to be shareable by different instances.
Note that if you pass `--user-directory` (but without an explicit `--cachedir`) to NetBeans (and I do, as I maintain several sets of configs for several projects), then the cache dir is AFAIK placed in `$userdir/var/cache`; at least on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists