[jira] [Comment Edited] (LUCENE-7168) Remove geo3d test leniency

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229180#comment-15229180 ] 

Karl Wright edited comment on LUCENE-7168 at 4/6/16 9:55 PM:
-------------------------------------------------------------

[~mikemccand] Yeah, please go ahead and push it, and I'll have a more detailed look.

I like the forensics; this will be very helpful.

I see your logic for the little test and yes it does look to me like there must be a bug of some sort.  I'll chase it down.


was (Author: kwright@metacarta.com):
[~mikemccand] Yeah, please go ahead and push it, and I'll have a more detailed look.

I like the forensics; this will be very helpful.

It's not immediately clear from the little test you wrote why we should expect the xyzsolid to have anything to do with the circle.  That's the only thing I'm scratching my head about.  The bad decision may well have taken place further up the chain of decisions.

> Remove geo3d test leniency
> --------------------------
>
>                 Key: LUCENE-7168
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7168
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>         Attachments: LUCENE-7168.patch, LUCENE-7168.patch, LUCENE-7168.patch, LUCENE-7168.patch, LUCENE-7168.patch
>
>
> Today the test hides possible failures by leniently handling quantization issues.
> We should fix it to do what geo2d tests now do: pre-quantized indexed points, but don't quantize query shapes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org