You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/06/16 15:41:26 UTC
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16086
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
ParquetMetadataUtils::ValidateColumnOffsets() returns an error if the end of
the column is beyond the end of the file (i.e. offset > end_of_file).
Instead, because there is a footer, the end of column must not be the end
of the file either, so it should use offset >= end_of_file. Otherwise,
a subsequent DCHECK in ParquetPageReader using the stricter condition will
fire.
Testing:
- Core job
Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
---
M be/src/exec/parquet/parquet-metadata-utils.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/16086/1
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 01:52:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 01:51:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
ParquetMetadataUtils::ValidateColumnOffsets() returns an error if the end of
the column is beyond the end of the file (i.e. offset > end_of_file).
Instead, because there is a footer, the end of column must not be the end
of the file either, so it should use offset >= end_of_file. Otherwise,
a subsequent DCHECK in ParquetPageReader using the stricter condition will
fire.
Testing:
- Core job
Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Reviewed-on: http://gerrit.cloudera.org:8080/16086
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-metadata-utils.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 20:30:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6015/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 01:52:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 06:47:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6339/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f
Gerrit-Change-Number: 16086
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 16:08:12 +0000
Gerrit-HasComments: No