You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/10 17:59:58 UTC
[GitHub] [arrow] assignUser opened a new pull request, #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
assignUser opened a new pull request, #13562:
URL: https://github.com/apache/arrow/pull/13562
@kou as requested in #13556 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13562:
URL: https://github.com/apache/arrow/pull/13562#issuecomment-1180375582
I have examples using sccache, for it ccache might be even better without the overhead of s3 storage?
With sccache for arrow:

With sccache for arrow + thirdparty toolchain:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13562:
URL: https://github.com/apache/arrow/pull/13562#issuecomment-1179772383
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #13562:
URL: https://github.com/apache/arrow/pull/13562#discussion_r917448736
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -758,6 +758,13 @@ set(EP_COMMON_CMAKE_ARGS
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=${CMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY}
-DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE})
+# Enable s/ccache if set by parent.
+if(CMAKE_CXX_COMPILER_LAUNCHER AND CMAKE_CXX_COMPILER_LAUNCHER)
Review Comment:
```suggestion
if(CMAKE_C_COMPILER_LAUNCHER AND CMAKE_CXX_COMPILER_LAUNCHER)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13562:
URL: https://github.com/apache/arrow/pull/13562#issuecomment-1179772380
https://issues.apache.org/jira/browse/ARROW-17034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13562:
URL: https://github.com/apache/arrow/pull/13562#issuecomment-1180170707
Do we have any hint that it improves build times? If so, then +1 for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13562:
URL: https://github.com/apache/arrow/pull/13562#issuecomment-1180378866
In any case the results look very nice, thank you :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #13562: ARROW-17034: [C++] Enable compiler caching for ThirdpartyToolchain.cmake
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #13562:
URL: https://github.com/apache/arrow/pull/13562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org