You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "kenmy (via GitHub)" <gi...@apache.org> on 2024/02/15 07:59:24 UTC

[PR] Making code example more compilable [calcite-site]

kenmy opened a new pull request, #6:
URL: https://github.com/apache/calcite-site/pull/6

   Line of code:
   `public final Employee[] emps = 0;`
   is not valid from java side. It was changed to 
   `public final Employee[] emps = new Employee[0];`
   This line can be compiled by Java compiler


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Making code example more compilable [calcite-site]

Posted by "kenmy (via GitHub)" <gi...@apache.org>.
kenmy commented on PR #6:
URL: https://github.com/apache/calcite-site/pull/6#issuecomment-2615291756

   Thnx @caicancai for copying this fix to the main calcite repository. I'm closing this now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Making code example more compilable [calcite-site]

Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on PR #6:
URL: https://github.com/apache/calcite-site/pull/6#issuecomment-1951618957

   Please note calcite-site's content is generated automatically via Github Actions, instead of committing manually. That said, calsite-site repository should not receive PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Making code example more compilable [calcite-site]

Posted by "kenmy (via GitHub)" <gi...@apache.org>.
kenmy closed pull request #6: Making code example more compilable
URL: https://github.com/apache/calcite-site/pull/6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Making code example more compilable [calcite-site]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #6:
URL: https://github.com/apache/calcite-site/pull/6#issuecomment-2365165174

   @kenmy Hi, You should modify the calcite code instead of the calcite-site


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org