You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2024/08/28 23:29:01 UTC
[Impala-ASF-CR] IMPALA-13327: bin/bootstrap toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE APACHE COMPONENTS=true
eubnara@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21732
Change subject: IMPALA-13327: bin/bootstrap_toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE_APACHE_COMPONENTS=true
......................................................................
IMPALA-13327: bin/bootstrap_toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE_APACHE_COMPONENTS=true
Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/21732/1
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 02 Nov 2024 08:12:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
eubnara@gmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Due to wrong unpack dir name for Apache HBase, it keeps downloading the same package which already exists
Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/21732/2
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13327: bin/bootstrap toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE APACHE COMPONENTS=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: bin/bootstrap_toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE_APACHE_COMPONENTS=true
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16830/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 00:00:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
eubnara@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
Patch Set 2:
Thanks for feedback. I changed the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 06:21:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16987/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 06:53:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21732/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21732/2//COMMIT_MSG@9
PS2, Line 9: Due to wrong unpack dir name for Apache HBase, it keeps downloading the same package which already exists
For the commit message, please wrap the line to be 72 characters. If you are using Vim, you can add these to your ~/.vimrc
syntax on
au FileType gitcommit setlocal tw=72
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 06:38:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11096/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 02 Nov 2024 08:13:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 02 Nov 2024 08:13:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Due to wrong unpack dir name for Apache HBase,
it keeps downloading the same package which already exists
Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Reviewed-on: http://gerrit.cloudera.org:8080/21732
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21732
to look at the new patch set (#3).
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Due to wrong unpack dir name for Apache HBase,
it keeps downloading the same package which already exists
Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/21732/3
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13327: bin/bootstrap toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE APACHE COMPONENTS=true
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: bin/bootstrap_toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE_APACHE_COMPONENTS=true
......................................................................
Patch Set 1:
(2 comments)
Thanks for fixing this!
http://gerrit.cloudera.org:8080/#/c/21732/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21732/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-13327: bin/bootstrap_toolchain.py always download hbase-2.6.0-hadoop3-bin.tar.gz when USE_APACHE_COMPONENTS=true
Can we use a shorter title? E.g. "Fix wrong unpack dir name for Apache HBase"
http://gerrit.cloudera.org:8080/#/c/21732/1//COMMIT_MSG@8
PS1, Line 8:
Could you explain how the issue happens in the commit message?
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 04:44:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13327: Fix wrong unpack dir name for Apache HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21732 )
Change subject: IMPALA-13327: Fix wrong unpack dir name for Apache HBase
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16797cea260c5c6c3c78cf04a5bb6a564ef3504c
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 02 Nov 2024 13:37:39 +0000
Gerrit-HasComments: No