You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/06/06 21:48:36 UTC
Re: Review Request 70751: Implemented V0 UPDATE_FRAMEWORK call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70751/#review215733
-----------------------------------------------------------
Ship it!
Looks good, will make the adjustments below and get this committed for you.
src/master/master.hpp
Lines 1058-1059 (original), 1058-1063 (patched)
<https://reviews.apache.org/r/70751/#comment302550>
How about some comments to help the reader navigate these overloads?
```
// Update framework via SchedulerDriver (i.e. no response
// code feedback, FrameworkErrorMessage on error).
void updateFramework(
const process::UPID& from,
mesos::scheduler::Call::UpdateFramework&& call);
// Update framework via HTTP API (i.e. returns 200 OK).
process::Future<process::http::Response> updateFramework(
mesos::scheduler::Call::UpdateFramework&& call);
```
src/master/master.cpp
Lines 3166 (patched)
<https://reviews.apache.org/r/70751/#comment302551>
The scheduler driver doesn't have a mechanism for this, so no need for this TODO
- Benjamin Mahler
On May 29, 2019, 6:32 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70751/
> -----------------------------------------------------------
>
> (Updated May 29, 2019, 6:32 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit implements the UPDATE_FRAMEWORK call in the V0 scheduler
> API. To help keep consistency between V1 and V0 APIs, the V0 call
> is implemented as a wrapper around V1 call, which converts HTTP
> responses with 4xx status codes into FrameworkErrorMessage.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2771f4c045c877b7d8aa5db042810232c0e40ba0
> src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b
>
>
> Diff: https://reviews.apache.org/r/70751/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>