You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2025/06/24 19:24:22 UTC
[PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
jamesfredley opened a new pull request, #14829:
URL: https://github.com/apache/grails-core/pull/14829
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #14829:
URL: https://github.com/apache/grails-core/pull/14829#issuecomment-3004874667
Based on https://github.com/apache/grails-core/blob/ead00352c90f2f7e263d64205302c3171873d99f/gradle/grails-extension-gradle-config.gradle#L28-L34
Given we use project() in these test projects, it appears we need to keep the dependency management plugin disabled and add grails-bom as a platform for testAndDevelopmentOnly.
This is different than generated apps, but we are moving in this direction: https://github.com/apache/grails-core/issues/14142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #14829:
URL: https://github.com/apache/grails-core/pull/14829#issuecomment-3002158674
```
* What went wrong:
Execution failed for task ':grails-test-examples-namespaces:bootJar'.
> Could not resolve all files for configuration ':grails-test-examples-namespaces:testAndDevelopmentOnly'.
> Could not find org.webjars.npm:jquery:.
Required by:
project :grails-test-examples-namespaces
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #14829:
URL: https://github.com/apache/grails-core/pull/14829#issuecomment-3003580130
Aha, this is why the platform is needed in the functional test apps:
https://github.com/apache/grails-core/blob/ead00352c90f2f7e263d64205302c3171873d99f/gradle/grails-extension-gradle-config.gradle#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #14829:
URL: https://github.com/apache/grails-core/pull/14829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #14829:
URL: https://github.com/apache/grails-core/pull/14829#issuecomment-3002105538
I was glad to remove `grails-bom` as a platform on `testAndDevelopmentOnly`. It appeared to be required when we switched from `implementation `to `developmentOnly `(https://github.com/apache/grails-core/actions/workflows/gradle.yml?query=branch%3Awebjars-developmentOnly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #14829:
URL: https://github.com/apache/grails-core/pull/14829#issuecomment-3003418275
> ```
> * What went wrong:
> Execution failed for task ':grails-test-examples-namespaces:bootJar'.
> > Could not resolve all files for configuration ':grails-test-examples-namespaces:testAndDevelopmentOnly'.
> > Could not find org.webjars.npm:jquery:.
> Required by:
> project :grails-test-examples-namespaces
> ```
That's interesting. Gradle seems to be able to resolve the webjar versions in apps generated by Forge, without the platform added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: scope webjars as testAndDevelopmentOnly [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #14829:
URL: https://github.com/apache/grails-core/pull/14829#issuecomment-3002028774
I'm not sure we need to add `grails-bom` as a platform to `testAndDevelopmentOnly` as it is a Spring configuration and we are adding it the bom to the Spring Dependency Management Plugin in `GrailsGradlePlugin`. It seems to work without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org