[jira] [Commented] (IMPALA-12415) Implement tests for graphical query timeline in webUI

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-12415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781112#comment-17781112 ] 

ASF subversion and git services commented on IMPALA-12415:
----------------------------------------------------------

Commit e9acc12a86c57e4456e35efe84fe4ecaeaa6f52a in impala's branch refs/heads/master from Surya Hebbar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e9acc12a8 ]

IMPALA-12415: Implement tests for graphical query timeline in webUI

To help with testing the query timeline web page, the tests have been
integrated using JEST testing framework based on nodejs.

'run_js_tests.sh' runs JEST test suits, after it fetches nodejs binaries
and related nodejs packages, if they are not present locally.

NodeJS binaries are stored within the ${IMPALA_TOOLCHAIN} directory.

'jest-environment-jsdom' supports rendering DOM elements and
testing them without the requirement of a browser.

For implementing unit and integration tests, the script
has been divided into multiple properly functioning modules,
that are imported as ES6 modules.

Unit tests have been written for the following query profile parsing
functions.

- mapTimeseriesCounters() - Test whether the method correctly searches
and maps the profile's counter's indexes based on counter_name even
in reverse order

- accumulateTimeseriesValues() - Test whether the method correctly
accumlates values after parsing values from 'data' in
'time_series_counters' while updating 'max_samples'

- generateTimesamples() - Test whether time sample values generated
based on 'max_samples' are correct, with different 'max_samples'

- clearTimeseriesValues() - Test whether Timeseries arrays are being
properly truncated in the correct range

- initializeUtilizationMetrics() - Test whether aggregate arrays and
time sample arrays are correctly allocated based on counters and
'max_samples'

- getSvg*() - Test whether all getSvg methods are correctly setting
attributes and returning expected attributes in elements

Unit tests produce JUnitXML for integration with jenkins jobs,
these are stored in ${IMPALA_JS_TEST_LOGS_DIR}.

Change-Id: I0caf0a0beee23821f78c0b3fe1aeb7dbf92d6a3e
Reviewed-on: http://gerrit.cloudera.org:8080/20538
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Implement tests for graphical query timeline in webUI
> -----------------------------------------------------
>
>                 Key: IMPALA-12415
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12415
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: Surya Hebbar
>            Assignee: Surya Hebbar
>            Priority: Major
>
> Manually testing the webUI's query timeline each time is unreliable and may produce edge cases, that are not always covered due to human error.
> To ensure proper functioning, as more features are incorporated, proper test cases along with a testing framework is required for the query timeline.
> As a first step, for implementing unit and integration tests, the query timeline's script should be divided into multiple properly functioning modules.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org