You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/09/22 08:23:15 UTC

[GitHub] andrzej-kaczmarek commented on a change in pull request #194: nimble/host: Convert BLE_GAP_MAX_UPDATE_ENTRIES from define to syscfg.

andrzej-kaczmarek commented on a change in pull request #194: nimble/host: Convert BLE_GAP_MAX_UPDATE_ENTRIES from define to syscfg.
URL: https://github.com/apache/mynewt-nimble/pull/194#discussion_r219665286
 
 

 ##########
 File path: nimble/host/syscfg.yml
 ##########
 @@ -171,6 +171,12 @@ syscfg.defs:
             for debugging.
         value: 0
 
+    # GAP options.
+    BLE_GAP_MAX_UPDATE_ENTRIES:
+        description: >
+            The maximum number of GAP update entries. (0/1)
 
 Review comment:
   We need a better name for this settings and also better description - "GAP update entry" refers to some internal name that really does not mean anything on app side. Something like `BLE_GAP_MAX_PENDING_CONN_PARAM_UPDATE` would be better. And not sure what `(0/1)` means here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services