[jira] [Commented] (FLINK-7797) Add support for windowed outer joins for streaming tables

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307886#comment-16307886 ] 

ASF GitHub Bot commented on FLINK-7797:
---------------------------------------

Github user xccui commented on the issue:

    https://github.com/apache/flink/pull/5140
  
    Hi @fhueske, thanks for your review. I've made the following changes to the PR.
    1. Fixes the "wrong sides" problem in `TimeBoundedStreamJoin`.
    2. Adds the logic for outer-joins with negative window size in `DataStreamWindowJoin`.
    3. Refines the `EmitAwareCollector` according to your suggestions.
    4. Uses a separate class `OuterJoinPaddingUtil` to deal with results padding.
    5. Adds some test cases to `JoinITCase` and `JoinHarnessTest`.
    6. Other minor changes to attribute/method/class names.
    
    Thanks, Xingcan


> Add support for windowed outer joins for streaming tables
> ---------------------------------------------------------
>
>                 Key: FLINK-7797
>                 URL: https://issues.apache.org/jira/browse/FLINK-7797
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>
> Currently, only windowed inner joins for streaming tables are supported.
> This issue is about adding support for windowed LEFT, RIGHT, and FULL OUTER joins.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)