You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <st...@dev.static-void.de> on 2016/01/28 00:34:43 UTC
Review Request 42879: Allow dots and hyphens in metric names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42879/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Maxim Khutornenko.
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description
-------
Allow dots and hyphens in metric names. This will make sure we won't warn about invalid stat names for valid job identifiers [1].
[1] https://github.com/apache/aurora/blob/0813e3a4445997b6a25a75f0401bbeb7aa87363b/api/src/main/thrift/org/apache/aurora/gen/api.thrift#L433
Diffs
-----
commons/src/main/java/org/apache/aurora/common/stats/Stats.java 613bdb9738ebb069722e9d9675a0590cf36ffb15
commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 5368ba5a0c9a98b4bf8142c7ab59c0864e201706
Diff: https://reviews.apache.org/r/42879/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Stephan Erb
Re: Review Request 42879: Allow dots and hyphens in metric names
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42879/#review116658
-----------------------------------------------------------
Ship it!
Master (e240fdc) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 27, 2016, 11:34 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42879/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 11:34 p.m.)
>
>
> Review request for Aurora, Joe Smith and Maxim Khutornenko.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow dots and hyphens in metric names. This will make sure we won't warn about invalid stat names for valid job identifiers [1].
>
> [1] https://github.com/apache/aurora/blob/0813e3a4445997b6a25a75f0401bbeb7aa87363b/api/src/main/thrift/org/apache/aurora/gen/api.thrift#L433
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/stats/Stats.java 613bdb9738ebb069722e9d9675a0590cf36ffb15
> commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 5368ba5a0c9a98b4bf8142c7ab59c0864e201706
>
> Diff: https://reviews.apache.org/r/42879/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 42879: Allow dots and hyphens in metric names
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42879/#review116679
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 27, 2016, 11:34 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42879/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 11:34 p.m.)
>
>
> Review request for Aurora, Joe Smith and Maxim Khutornenko.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow dots and hyphens in metric names. This will make sure we won't warn about invalid stat names for valid job identifiers [1].
>
> [1] https://github.com/apache/aurora/blob/0813e3a4445997b6a25a75f0401bbeb7aa87363b/api/src/main/thrift/org/apache/aurora/gen/api.thrift#L433
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/stats/Stats.java 613bdb9738ebb069722e9d9675a0590cf36ffb15
> commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 5368ba5a0c9a98b4bf8142c7ab59c0864e201706
>
> Diff: https://reviews.apache.org/r/42879/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>