You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/07/17 09:43:27 UTC

[GitHub] [libcloud] Kami opened a new pull request #1315: [WIP] Various Gridscale driver improvements

Kami opened a new pull request #1315: [WIP] Various Gridscale driver improvements
URL: https://github.com/apache/libcloud/pull/1315
 
 
   While testing Gridscale drivers I noticed some issues which I originally missed during the code review.
   
   This pull request fixes some of those issues and implements some new functionality for the completeness sake.
   
   1. Add missing ``encode_data()`` method on the Connection class and rely on that for encoding request body (data) instead of doing it manually instead the driver methods.
   
      This way it follows Libcloud API which means it works correctly with logging connection and other abstractions.
   
   2. Implement ``import_key_pair_from_string`` / ``import_key_pair_from_file`` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services