You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2017/04/24 19:20:04 UTC
[jira] [Commented] (GUACAMOLE-282) Common surface transfer
functions incorrect with respect to alpha channel
[ https://issues.apache.org/jira/browse/GUACAMOLE-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981721#comment-15981721 ]
Michael Jumper commented on GUACAMOLE-282:
------------------------------------------
*NOTE:* This mainly affects RDP. The other protocols do not use binary raster operations.
> Common surface transfer functions incorrect with respect to alpha channel
> -------------------------------------------------------------------------
>
> Key: GUACAMOLE-282
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-282
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 0.9.12-incubating
> Reporter: Michael Jumper
> Assignee: Michael Jumper
> Priority: Critical
>
> The common surface implementation used within guacamole-server is incorrect with respect to binary transfer functions as of GUACAMOLE-188, which added support for the alpha channel to the common surface.
> Prior to GUACAMOLE-188, the common surface supported only the red, green, and blue channels, thus simple binary operations correctly mirrored those of the JavaScript Guacamole client.
> After GUACAMOLE-188, the contents of a surface might have alpha channel values, which are not supposed to be taken into account for all transfer functions. The JavaScript client actually only pays attention to the alpha channel for the following transfer functions:
> * {{GUAC_TRANSFER_BINARY_SRC}} (alpha channel becomes a copy of source)
> * {{GUAC_TRANSFER_BINARY_NSRC}} (alpha channel becomes a copy of source and is NOT INVERTED)
> In all other cases, the alpha channel of the destination is preserved.
> The common surface must be modified to duplicate this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)