[jira] [Commented] (MESOS-3885) Remove apply-review.sh script from repository.

["Joseph Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012070#comment-15012070 ] 

Joseph Wu commented on MESOS-3885:
----------------------------------

Before we remove {{apply-review.sh}}, we should probably add an option to {{apply-reviews.py}} to apply a single review.

Right now, if you have a chain like:
{code}
1 -> 2 -> 3
{code}

It is non-trivial to go from having review 2 applied; to having review 3 applied.  i.e.
{code}
apply-reviews.py -n -r 2
apply-reviews.py -n -r 3 # Tries to apply review 1 again => bad patch :(
{code}

> Remove apply-review.sh script from repository.
> ----------------------------------------------
>
>                 Key: MESOS-3885
>                 URL: https://issues.apache.org/jira/browse/MESOS-3885
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Artem Harutyunyan
>
> Since apply-reviews.py script was introduced there is no need anymore to keep the apply-review.sh around. apply-review.sh should be removed soon after apply-reviews.py ships.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)