You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/26 09:10:41 UTC

[GitHub] [dubbo-go] alchemy-lee opened a new pull request #1413: Fix: Generic invocation failed when the response type is a slice

alchemy-lee opened a new pull request #1413:
URL: https://github.com/apache/dubbo-go/pull/1413


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**:
   
   This PR fixes the generic invocation bug when the response type is a slice of the pointer. Most of the code is the same as the 3.0 branch, which is committed by @xavier-niu. Since the generic invocation in v1.5 only supports `MapGeneralizer`, I do not introduce the `Generalizer` interface.
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #1412 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1413: Fix: Generic invocation failed when the response type is a slice

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1413:
URL: https://github.com/apache/dubbo-go/pull/1413


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] xavier-niu commented on pull request #1413: Fix: Generic invocation failed when the response type is a slice

Posted by GitBox <gi...@apache.org>.
xavier-niu commented on pull request #1413:
URL: https://github.com/apache/dubbo-go/pull/1413#issuecomment-906246707


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] alchemy-lee commented on pull request #1413: Fix: Generic invocation failed when the response type is a slice

Posted by GitBox <gi...@apache.org>.
alchemy-lee commented on pull request #1413:
URL: https://github.com/apache/dubbo-go/pull/1413#issuecomment-906260234


   > The sample of generic invocation should be updated as well.
   
   I have updated the sample in this PR: https://github.com/apache/dubbo-go-samples/pull/210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] xavier-niu commented on pull request #1413: Fix: Generic invocation failed when the response type is a slice

Posted by GitBox <gi...@apache.org>.
xavier-niu commented on pull request #1413:
URL: https://github.com/apache/dubbo-go/pull/1413#issuecomment-906252929


   The sample of generic invocation should be updated as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org