You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/04/03 16:28:46 UTC

[GitHub] Antonio-Maranhao opened a new pull request #1071: Only use update and stable query params when set

Antonio-Maranhao opened a new pull request #1071: Only use update and stable query params when set
URL: https://github.com/apache/couchdb-fauxton/pull/1071
 
 
   ## Overview
   
   Document list doesn't work with older CouchDB versions that don't support the `update` and `stable` parameters because Fauxton always adds the parameters as part of the GET requests. 
   
   The proposed fix is to only send these params when they're set in the Query Options panel to a value other than their default.
   
   ## Testing recommendations
   
   - Go to the All Documents list
   - Using the network tab in the browser's devtools, check the `update` and `stable` parameters are no longer being sent.
   - Open the Query Options panel. Change the values of `update` and `stable` parameters.
   - Check the params are now added to the GET requests
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct tag once a new Fauxton release is made
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services