[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #657: [#408] test: fix memory check failure in ShuffleBufferManagerTest#bufferSizeTest

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #657:
URL: https://github.com/apache/incubator-uniffle/pull/657#discussion_r1117867437


##########
server/src/test/java/org/apache/uniffle/server/buffer/ShuffleBufferManagerTest.java:
##########
@@ -621,5 +621,10 @@ private void waitForFlush(ShuffleFlushManager shuffleFlushManager,
         fail("Flush data time out");
       }
     } while (committedCount < expectedBlockNum);
+
+    // Need to wait for `event.doCleanup` to be executed
+    // to ensure the correctness of subsequent checks of
+    // `shuffleBufferManager.getUsedMemory()` and `shuffleBufferManager.getInFlushSize()`.
+    Thread.sleep(100);

Review Comment:
   is there some to ensure event.doCleanup is executed?
   
   This still could be flaky. But I'm ok to merge if there's no easy way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org