You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/04/05 20:43:27 UTC

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing

michaelandrepearce commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing
URL: https://github.com/apache/activemq-artemis/pull/2610#discussion_r272737781
 
 

 ##########
 File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
 ##########
 @@ -1669,12 +1669,24 @@
    </xsd:complexType>
 
    <xsd:complexType name="federationTransformerType">
-      <xsd:complexContent>
-         <xsd:extension base="transformerType">
-            <xsd:attribute name="name" type="xsd:ID" use="required" />
-            <xsd:attributeGroup ref="xml:specialAttrs"/>
-         </xsd:extension>
-      </xsd:complexContent>
+      <xsd:sequence>
 
 Review comment:
   Its fine. It was valid xsd thats a nasty ibm bug, but you change doesnt break anything just causes us to duplicate schema bits. So im happy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services