[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #797:
URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r433678132



##########
File path: libminifi/include/core/ConfigurableComponent.h
##########
@@ -216,16 +216,20 @@ bool ConfigurableComponent::getProperty(const std::string name, T &value) const{
 
    auto &&it = properties_.find(name);

Review comment:
       no idea, removed it, but it is an universal reference and will bind everything, useful when the expression returns a proxy reference, e.g. when accessing elements of `std::vector<bool>`, I mostly use them in range-based loops, but generally makes people think that you are doing something funny, so I would use them with great care




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org