You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2026/07/24 14:58:58 UTC

svn commit: r1936554 - pdfbox/branches/2.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel

Author: tilman
Date: Fri Jul 24 14:58:58 2026
New Revision: 1936554

Log:
PDFBOX-6212: add comment based on comment by user robo

Modified:
   pdfbox/branches/2.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java

Modified: pdfbox/branches/2.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
==============================================================================
--- pdfbox/branches/2.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java	Fri Jul 24 14:58:55 2026	(r1936553)
+++ pdfbox/branches/2.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java	Fri Jul 24 14:58:58 2026	(r1936554)
@@ -1037,6 +1037,9 @@ public class TestCreateSignature
         {
             BasicOCSPResp basicResponse = (BasicOCSPResp) ocspResp.getResponseObject();
             Assert.assertEquals(OCSPResponseStatus.SUCCESSFUL, ocspResp.getStatus());
+            // A failure here may also be caused by a TSA whose BasicOCSPResponse does not include
+            // embedded responder certificates, e.g. DigiCert's TSA (http://timestamp.digicert.com).
+            // This is optional, see https://datatracker.ietf.org/doc/html/rfc6960 and search for BasicOCSPResponse.
             Assert.assertTrue("OCSP should have at least 1 certificate", basicResponse.getCerts().length >= 1);
             BEROctetString encodedSignature = new BEROctetString(basicResponse.getSignature());
             byte[] ocspSignatureHash = MessageDigest.getInstance("SHA-1").digest(encodedSignature.getEncoded());