You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/17 03:26:55 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3061: Separate CONFIG_BCH from CONFIG_DISABLE_MOUNTPOINT
xiaoxiang781216 commented on a change in pull request #3061:
URL: https://github.com/apache/incubator-nuttx/pull/3061#discussion_r595685849
##########
File path: boards/arm/stm32l4/stm32l476vg-disco/src/stm32_appinit.c
##########
@@ -269,6 +269,7 @@ int board_app_initialize(uintptr_t arg)
snprintf(blockdev, 18, "/dev/mtdblock%d", N25QXXX_MTD_MINOR);
snprintf(chardev, 12, "/dev/mtd%d", N25QXXX_MTD_MINOR);
+#if defined(CONFIG_BCH)
Review comment:
should we move this statement before line 269 too? Since blockdev and chardev isn't really used too in case CONFIG_BCH = n. The guard at line 137 need to change too.
##########
File path: boards/arm/samv7/samv71-xult/src/sam_bringup.c
##########
@@ -435,6 +435,7 @@ int sam_bringup(void)
snprintf(blockdev, 18, "/dev/mtdblock%d", S25FL1_MTD_MINOR);
snprintf(chardev, 12, "/dev/mtd%d", S25FL1_MTD_MINOR);
+#if defined(CONFIG_BCH)
Review comment:
ditto
##########
File path: boards/arm/sama5/sama5d4-ek/src/sam_at25.c
##########
@@ -132,6 +132,7 @@ int sam_at25_automount(int minor)
snprintf(blockdev, 18, "/dev/mtdblock%d", minor);
snprintf(chardev, 12, "/dev/mtd%d", minor);
+#if defined(CONFIG_BCH)
Review comment:
ditto
##########
File path: boards/arm/samv7/same70-xplained/src/sam_bringup.c
##########
@@ -290,6 +290,7 @@ int sam_bringup(void)
snprintf(blockdev, 18, "/dev/mtdblock%d", PROGMEM_MTD_MINOR);
snprintf(chardev, 12, "/dev/mtd%d", PROGMEM_MTD_MINOR);
+#if defined(CONFIG_BCH)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org