mod_proxy/1832: ProxyDomain directive logs incorrect error messages

[Martin Kraemer <ma...@apache.org>]

>Number:         1832
>Category:       mod_proxy
>Synopsis:       ProxyDomain directive logs incorrect error messages
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Wed Feb 18 08:50:01 PST 1998
>Last-Modified:
>Originator:     martin@apache.org
>Organization:
apache
>Release:        1.3b5
>Environment:
any
>Description:
The ProxyDomain directive uses aplog_error() to log possible redirections.
Unfortunately, an URI can (and often will) contain '%'-encoded metachars
like '~'->'%7E' which are then mistaken as printf() percent tokens.

Oh, and the table_get("Referer") semantics apparently changed: it now returns
"-" instead of NULL which then leads to a log message "... from -" (the
intention was to suppress the "from" part if the referer was undefined).
>How-To-Repeat:

>Fix:
For the first part, the fix is easy: add an extra >>"%s",<< in front of the
pstrdup() call in the aplog_error() call.
The second problem is easy to fix as well:
check for (ref!= NULL && !strcmp(ref, "-"))
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <ap...@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]