You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mebelousov <gi...@git.apache.org> on 2018/06/19 13:45:24 UTC

[GitHub] zeppelin pull request #3035: [ZEPPELIN-3553] Fix URLs for "Notebook Permissi...

GitHub user mebelousov opened a pull request:

    https://github.com/apache/zeppelin/pull/3035

    [ZEPPELIN-3553] Fix URLs for "Notebook Permission" and "Shiro Authentic…

    ### What is this PR for?
    On page Setup > Multi-user Support http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/basics/multi_user_support.html
    there are two urls:
    * Shiro Authentication - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/setup/security/shiro_authentication.html
    * Notebook Permission - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/setup/security/notebook_authorization.html
    
    Need to remove one of the "setup"
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-3553](https://issues.apache.org/jira/browse/ZEPPELIN-3553)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no 
    * Does this needs documentation? no 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3553

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3035.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3035
    
----
commit 100a2af06332411e69794c9e7a94c66227f54ef7
Author: mebelousov <me...@...>
Date:   2018-06-19T13:38:10Z

    ZEPPELIN-3553 Fix URLs for "Notebook Permission" and "Shiro Authentication"

----


---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    @felixcheung done


---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    looks like we should port to branch-0.8 too


---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    we don't have a 0.9 branch or plan yet. should we backport to 0.8? are we having another release, like 0.8.1?


---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    merging if no more comment


---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs for "Notebook Permission" and...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    can you fix up the truncated PR title?


---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    @felixcheung Links are still broken in 0.9.0 and 0.8 docs. Could you check the reason?


---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    I don't this is ported to 0.8 https://github.com/apache/zeppelin/commits/branch-0.8



---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3035
  
    I plan to have 0.8.1 release for critical bug fixes. So please merge to branch-0.8 as well


---

[GitHub] zeppelin pull request #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3035


---