You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/06/18 17:06:27 UTC

[GitHub] [submarine] wang0630 opened a new pull request #317: [SUBMARINE-529] Change apiVersion

wang0630 opened a new pull request #317:
URL: https://github.com/apache/submarine/pull/317


   ### What is this PR for?
   k8s installed by kind 0.8.0 seems that it does not support apiVersion apps/v1beta1 anymore.
   
   Change to apps/v1 to build successfully.
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-529
   
   ### How should this be tested?
   https://travis-ci.com/github/wang0630/submarine/builds/172083779
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #317: SUBMARINE-529. Change apiVersion

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #317:
URL: https://github.com/apache/submarine/pull/317


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] wang0630 commented on pull request #317: SUBMARINE-529. Change apiVersion

Posted by GitBox <gi...@apache.org>.
wang0630 commented on pull request #317:
URL: https://github.com/apache/submarine/pull/317#issuecomment-647128464


   > The `deployment` resource supports `apps/v1` version in v1.14 and the minimum version number of K8s submarine supports is v1.14. So this PR LGTM, if no more comments I will merge it later.
   
   Noted with thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] tangzhankun commented on pull request #317: SUBMARINE-529. Change apiVersion

Posted by GitBox <gi...@apache.org>.
tangzhankun commented on pull request #317:
URL: https://github.com/apache/submarine/pull/317#issuecomment-646510048


   @wang0630 thanks for the update. The`Deployment`'s `apiVersion: apps/v1` is depending on the k8s version instead of kind. "Kind" is just a testing tool.
   IIRC, from v1.16, the "apps/v1beta1" is deprecated. It's better that we improve our helm charts to support installation on all k8s version. If no possible, I'm fine with this PR in first.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org