You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xy720 (via GitHub)" <gi...@apache.org> on 2025/04/29 06:53:11 UTC
[PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
xy720 opened a new pull request, #50535:
URL: https://github.com/apache/doris/pull/50535
### What problem does this PR solve?
related pr: #45255
Currently, when the MS drop node/drop cluster api is called to the drop sql node/sql cluster, there is a 5 minute safe drop protection mechanism, but it is not necessary when destroying a newly created doris instance.
1. Allow bypassing the safe-time-check when calling the drop cluster api of meta service by setting the safe_derop_on_sql_cluster param to false
2. Add a configuration for the safe-time-check (default 5 minutes) to adjust this value
Api call example:
curl -X POST -H "Content-Type: text/plain" -d '{"instance_id": "123333", "cluster": {"cluster_name": "RESERVED_CLUSTER_NAME_FOR_SQL_SERVER", "cluster_id": "RESERVED_CLUSTER_ID_FOR_SQL_SERVER"}, "safe_drop_on_sql_cluster": "false"}' http://127.0.0.1:5000/MetaService/http/drop_cluster?token=xxxxxxxx
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2837726502
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2854124714
<details>
<summary>TPC-H: <b>Total hot run time: 33973 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 265e57f63ce9f19a43980ef69eb8009a1ba66c33, data reload: false
------ Round 1 ----------------------------------
q1 25921 5088 4989 4989
q2 2060 279 183 183
q3 10389 1289 701 701
q4 10236 1011 530 530
q5 7598 2416 2349 2349
q6 185 167 137 137
q7 968 774 639 639
q8 9371 1472 1120 1120
q9 7584 5078 5099 5078
q10 6857 2332 1883 1883
q11 489 288 269 269
q12 358 351 215 215
q13 17779 3648 3078 3078
q14 228 241 212 212
q15 530 491 477 477
q16 413 426 364 364
q17 594 860 365 365
q18 7613 7319 7192 7192
q19 1599 949 551 551
q20 326 323 213 213
q21 3969 3375 2475 2475
q22 1019 1007 953 953
Total cold run time: 116086 ms
Total hot run time: 33973 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5172 5064 5072 5064
q2 224 334 237 237
q3 2179 2644 2281 2281
q4 1334 1822 1408 1408
q5 4423 4426 4397 4397
q6 230 168 129 129
q7 1987 1949 1757 1757
q8 2587 2545 2522 2522
q9 7258 7213 7036 7036
q10 2988 3170 2734 2734
q11 565 519 488 488
q12 676 767 600 600
q13 3576 3925 3312 3312
q14 290 317 287 287
q15 517 486 473 473
q16 441 477 442 442
q17 1171 1602 1368 1368
q18 7741 7596 7403 7403
q19 799 778 968 778
q20 1981 1975 1832 1832
q21 5019 4826 4753 4753
q22 1096 1040 1060 1040
Total cold run time: 52254 ms
Total hot run time: 50341 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2854171741
<details>
<summary>ClickBench: <b>Total hot run time: 29.67 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 265e57f63ce9f19a43980ef69eb8009a1ba66c33, data reload: false
query1 0.04 0.04 0.03
query2 0.14 0.10 0.11
query3 0.35 0.19 0.19
query4 1.59 0.20 0.08
query5 0.56 0.56 0.54
query6 1.19 0.71 0.71
query7 0.02 0.02 0.02
query8 0.05 0.05 0.04
query9 0.61 0.51 0.52
query10 0.58 0.59 0.58
query11 0.25 0.12 0.12
query12 0.26 0.13 0.14
query13 0.63 0.61 0.61
query14 0.80 0.82 0.81
query15 0.95 0.88 0.87
query16 0.38 0.38 0.36
query17 1.03 1.04 1.05
query18 0.18 0.19 0.17
query19 1.95 1.88 1.83
query20 0.01 0.01 0.01
query21 15.40 0.97 0.67
query22 0.94 1.08 0.88
query23 14.67 1.50 0.76
query24 5.04 0.59 0.32
query25 0.16 0.09 0.08
query26 0.55 0.23 0.18
query27 0.08 0.08 0.09
query28 11.08 1.14 0.56
query29 12.55 4.06 3.40
query30 0.28 0.10 0.06
query31 2.83 0.62 0.42
query32 3.22 0.59 0.50
query33 3.15 3.04 3.09
query34 16.63 5.08 4.38
query35 4.52 4.43 4.41
query36 0.63 0.54 0.50
query37 0.20 0.19 0.17
query38 0.16 0.16 0.16
query39 0.05 0.04 0.05
query40 0.18 0.16 0.16
query41 0.11 0.05 0.05
query42 0.06 0.05 0.06
query43 0.05 0.05 0.05
Total cold run time: 104.11 s
Total hot run time: 29.67 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2856870272
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2854676454
# BE Regression && UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50535_265e57f63ce9f19a43980ef69eb8009a1ba66c33_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50535_265e57f63ce9f19a43980ef69eb8009a1ba66c33_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 81.02% (21260/26241) |
| Line Coverage | 74.93% (219870/293420) |
| Region Coverage | 73.25% (132268/180564) |
| Branch Coverage | 66.62% (67582/101438) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2859372350
run cloudut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2853863422
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2856948506
<details>
<summary>ClickBench: <b>Total hot run time: 29.29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.11
query3 0.26 0.19 0.20
query4 1.59 0.20 0.19
query5 0.60 0.60 0.54
query6 1.19 0.71 0.71
query7 0.02 0.02 0.01
query8 0.04 0.03 0.04
query9 0.58 0.52 0.54
query10 0.56 0.57 0.58
query11 0.15 0.11 0.10
query12 0.15 0.11 0.12
query13 0.62 0.60 0.59
query14 0.78 0.81 0.81
query15 0.86 0.85 0.86
query16 0.38 0.38 0.38
query17 1.06 1.04 1.05
query18 0.21 0.19 0.19
query19 1.96 1.85 1.76
query20 0.02 0.02 0.01
query21 15.40 0.91 0.55
query22 0.76 1.20 0.71
query23 14.90 1.40 0.61
query24 6.73 1.60 0.97
query25 0.51 0.20 0.06
query26 0.60 0.17 0.14
query27 0.06 0.05 0.05
query28 9.74 0.91 0.42
query29 12.61 4.01 3.28
query30 0.26 0.08 0.06
query31 2.83 0.61 0.38
query32 3.22 0.53 0.46
query33 3.10 3.08 3.01
query34 15.78 5.08 4.52
query35 4.55 4.53 4.56
query36 0.67 0.50 0.48
query37 0.09 0.06 0.06
query38 0.06 0.05 0.04
query39 0.03 0.03 0.03
query40 0.16 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.4 s
Total hot run time: 29.29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2857003379
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a_66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a_66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.52% (14847/26743) |
| Line Coverage | 44.54% (130933/293937) |
| Region Coverage | 43.28% (66701/154123) |
| Branch Coverage | 37.88% (33658/88862) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2837923242
<details>
<summary>TPC-H: <b>Total hot run time: 34437 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c059e1d5284189e5784b9493a1328200fe33d2df, data reload: false
------ Round 1 ----------------------------------
q1 26011 6033 5117 5117
q2 2101 291 192 192
q3 10431 1280 717 717
q4 10234 1022 542 542
q5 7533 2406 2414 2406
q6 187 168 140 140
q7 960 756 626 626
q8 9326 1346 1177 1177
q9 6853 5221 5167 5167
q10 6887 2329 1880 1880
q11 478 296 276 276
q12 350 355 216 216
q13 17767 3690 3103 3103
q14 230 237 210 210
q15 526 500 483 483
q16 434 437 386 386
q17 625 869 381 381
q18 7685 7167 7154 7154
q19 2554 1577 559 559
q20 330 338 216 216
q21 4214 3433 2495 2495
q22 1100 994 1010 994
Total cold run time: 116816 ms
Total hot run time: 34437 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5384 5134 5131 5131
q2 239 324 239 239
q3 2154 2643 2320 2320
q4 1454 1943 1472 1472
q5 4512 4409 4403 4403
q6 212 167 128 128
q7 1998 1906 1766 1766
q8 2680 2632 2602 2602
q9 7295 6974 7135 6974
q10 3009 3211 2780 2780
q11 591 540 497 497
q12 672 767 631 631
q13 3566 3925 3646 3646
q14 285 291 275 275
q15 519 480 469 469
q16 435 501 443 443
q17 1190 1535 1465 1465
q18 7840 7670 7603 7603
q19 862 890 974 890
q20 1906 1980 1951 1951
q21 5227 4781 4781 4781
q22 1138 1104 1049 1049
Total cold run time: 53168 ms
Total hot run time: 51515 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838144580
run cloud_ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838480759
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2837968461
<details>
<summary>ClickBench: <b>Total hot run time: 29.9 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c059e1d5284189e5784b9493a1328200fe33d2df, data reload: false
query1 0.03 0.03 0.03
query2 0.15 0.11 0.12
query3 0.35 0.20 0.20
query4 1.59 0.21 0.19
query5 0.61 0.61 0.63
query6 1.18 0.75 0.71
query7 0.03 0.01 0.02
query8 0.06 0.05 0.04
query9 0.62 0.52 0.51
query10 0.57 0.57 0.58
query11 0.26 0.12 0.13
query12 0.26 0.13 0.13
query13 0.63 0.63 0.62
query14 0.78 0.82 0.81
query15 0.95 0.88 0.88
query16 0.40 0.37 0.36
query17 1.04 1.04 1.02
query18 0.19 0.18 0.19
query19 1.92 1.78 1.83
query20 0.01 0.01 0.01
query21 15.39 0.98 0.66
query22 0.92 1.08 0.76
query23 14.68 1.52 0.75
query24 5.18 0.59 0.31
query25 0.16 0.09 0.08
query26 0.55 0.23 0.18
query27 0.08 0.10 0.09
query28 11.05 1.17 0.57
query29 12.53 4.12 3.49
query30 0.28 0.09 0.07
query31 2.81 0.63 0.43
query32 3.22 0.59 0.51
query33 3.09 3.03 3.08
query34 16.73 5.18 4.46
query35 4.46 4.46 4.47
query36 0.64 0.51 0.49
query37 0.20 0.17 0.17
query38 0.16 0.16 0.17
query39 0.05 0.05 0.04
query40 0.20 0.16 0.16
query41 0.11 0.05 0.05
query42 0.06 0.05 0.05
query43 0.06 0.05 0.04
Total cold run time: 104.24 s
Total hot run time: 29.9 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2858124149
run cloud_ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2854155980
<details>
<summary>TPC-DS: <b>Total hot run time: 192533 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 265e57f63ce9f19a43980ef69eb8009a1ba66c33, data reload: false
query1 1424 1089 1057 1057
query2 6201 1804 1801 1801
query3 11040 4601 4645 4601
query4 56094 26017 23184 23184
query5 5172 461 452 452
query6 339 206 193 193
query7 4918 495 276 276
query8 328 256 236 236
query9 6026 2562 2574 2562
query10 431 314 267 267
query11 15061 14982 14869 14869
query12 165 113 106 106
query13 1110 529 393 393
query14 10236 6319 6422 6319
query15 221 198 191 191
query16 7164 652 522 522
query17 1103 762 611 611
query18 1560 404 322 322
query19 214 213 167 167
query20 127 119 136 119
query21 209 125 107 107
query22 4346 4421 4369 4369
query23 33977 33285 33434 33285
query24 6518 2415 2433 2415
query25 449 464 407 407
query26 701 272 158 158
query27 2265 497 331 331
query28 3284 2095 2111 2095
query29 578 548 428 428
query30 273 226 190 190
query31 869 859 801 801
query32 73 63 62 62
query33 459 353 307 307
query34 754 852 513 513
query35 821 851 769 769
query36 924 975 896 896
query37 106 111 78 78
query38 4173 4236 4253 4236
query39 1511 1472 1416 1416
query40 215 126 113 113
query41 55 52 52 52
query42 117 108 112 108
query43 502 482 473 473
query44 1272 811 818 811
query45 190 184 170 170
query46 853 1018 635 635
query47 1855 1861 1821 1821
query48 387 409 313 313
query49 711 520 433 433
query50 643 708 418 418
query51 4206 4240 4226 4226
query52 110 104 108 104
query53 217 249 185 185
query54 587 575 522 522
query55 84 79 80 79
query56 295 302 306 302
query57 1195 1176 1139 1139
query58 257 254 258 254
query59 2697 2768 2654 2654
query60 339 324 315 315
query61 132 129 126 126
query62 728 734 689 689
query63 223 188 186 186
query64 1821 1005 699 699
query65 4305 4237 4258 4237
query66 719 385 299 299
query67 16087 15491 15235 15235
query68 7737 866 503 503
query69 538 302 267 267
query70 1142 1109 1101 1101
query71 481 311 286 286
query72 5511 4748 4885 4748
query73 1433 673 349 349
query74 9118 9140 8999 8999
query75 3759 3184 2690 2690
query76 4194 1236 748 748
query77 615 365 294 294
query78 9929 10163 9307 9307
query79 2111 810 572 572
query80 833 505 439 439
query81 493 255 215 215
query82 430 126 94 94
query83 361 246 236 236
query84 297 105 86 86
query85 810 341 308 308
query86 383 313 297 297
query87 4436 4359 4323 4323
query88 3268 2214 2212 2212
query89 399 312 276 276
query90 1943 200 203 200
query91 147 138 108 108
query92 69 59 56 56
query93 1160 914 578 578
query94 694 467 314 314
query95 365 284 280 280
query96 473 560 271 271
query97 3150 3261 3154 3154
query98 242 205 204 204
query99 1407 1431 1309 1309
Total cold run time: 299954 ms
Total hot run time: 192533 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #50535:
URL: https://github.com/apache/doris/pull/50535#discussion_r2065655504
##########
gensrc/proto/cloud.proto:
##########
@@ -1108,6 +1108,8 @@ message AlterClusterRequest {
optional Operation op = 4;
// for SQL mode rename cluster, rename to cluster name eq instance empty cluster name, need drop empty cluster
optional bool replace_if_existing_empty_target_cluster = 5;
+ // if true, check if drop_cluster op on sql type cluster is in safe time
+ optional bool safe_drop_on_sql_cluster = 6 [default = true];
Review Comment:
pls do not use default value, or there will be too many assumptions to be considered in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838144309
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838480590
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2856927307
<details>
<summary>TPC-H: <b>Total hot run time: 33890 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a, data reload: false
------ Round 1 ----------------------------------
q1 26245 5063 5009 5009
q2 2066 276 195 195
q3 10750 1235 701 701
q4 10253 1014 528 528
q5 8122 2426 2323 2323
q6 186 164 133 133
q7 937 761 620 620
q8 9320 1291 1058 1058
q9 6840 5082 5086 5082
q10 6830 2329 1887 1887
q11 459 277 264 264
q12 358 360 219 219
q13 17764 3684 3119 3119
q14 223 232 218 218
q15 544 480 487 480
q16 424 441 375 375
q17 600 853 366 366
q18 7760 7128 7197 7128
q19 1427 993 558 558
q20 338 348 217 217
q21 4271 3482 2472 2472
q22 1020 959 938 938
Total cold run time: 116737 ms
Total hot run time: 33890 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5171 5054 5054 5054
q2 240 326 229 229
q3 2144 2648 2267 2267
q4 1367 1791 1463 1463
q5 4565 4447 4423 4423
q6 216 167 131 131
q7 1988 1848 1739 1739
q8 2595 2866 2615 2615
q9 7186 7144 7347 7144
q10 3039 3205 2756 2756
q11 578 503 499 499
q12 669 730 608 608
q13 3525 3887 3257 3257
q14 284 297 265 265
q15 527 478 474 474
q16 439 481 444 444
q17 1191 1647 1416 1416
q18 7758 7566 7421 7421
q19 829 859 973 859
q20 1955 2067 1821 1821
q21 4962 4617 4661 4617
q22 1057 1016 961 961
Total cold run time: 52285 ms
Total hot run time: 50463 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on code in PR #50535:
URL: https://github.com/apache/doris/pull/50535#discussion_r2065666422
##########
gensrc/proto/cloud.proto:
##########
@@ -1108,6 +1108,8 @@ message AlterClusterRequest {
optional Operation op = 4;
// for SQL mode rename cluster, rename to cluster name eq instance empty cluster name, need drop empty cluster
optional bool replace_if_existing_empty_target_cluster = 5;
+ // if true, check if drop_cluster op on sql type cluster is in safe time
+ optional bool safe_drop_on_sql_cluster = 6 [default = true];
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838103492
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c059e1d5284189e5784b9493a1328200fe33d2df_c059e1d5284189e5784b9493a1328200fe33d2df/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c059e1d5284189e5784b9493a1328200fe33d2df_c059e1d5284189e5784b9493a1328200fe33d2df/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.67% (14741/26962) |
| Line Coverage | 43.77% (129215/295201) |
| Region Coverage | 42.48% (65950/155244) |
| Branch Coverage | 37.06% (33256/89726) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2854284105
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/265e57f63ce9f19a43980ef69eb8009a1ba66c33_265e57f63ce9f19a43980ef69eb8009a1ba66c33/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/265e57f63ce9f19a43980ef69eb8009a1ba66c33_265e57f63ce9f19a43980ef69eb8009a1ba66c33/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.51% (14845/26743) |
| Line Coverage | 44.54% (130910/293933) |
| Region Coverage | 43.27% (66688/154123) |
| Branch Coverage | 37.87% (33655/88862) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2856943524
<details>
<summary>TPC-DS: <b>Total hot run time: 185051 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a, data reload: false
query1 1027 477 509 477
query2 6590 1838 1793 1793
query3 6755 219 218 218
query4 26632 23303 23140 23140
query5 4311 653 480 480
query6 291 194 183 183
query7 4618 487 276 276
query8 285 253 248 248
query9 8571 2544 2541 2541
query10 478 310 260 260
query11 15647 15146 14811 14811
query12 165 113 108 108
query13 1635 544 389 389
query14 8726 6093 6519 6093
query15 224 187 171 171
query16 7139 625 476 476
query17 948 723 582 582
query18 1970 412 305 305
query19 194 193 161 161
query20 123 116 118 116
query21 220 127 107 107
query22 4042 4223 4064 4064
query23 33691 32835 33081 32835
query24 8478 2408 2370 2370
query25 574 482 413 413
query26 1245 268 162 162
query27 2752 502 338 338
query28 4358 2074 2058 2058
query29 767 539 425 425
query30 279 214 181 181
query31 938 855 762 762
query32 78 64 63 63
query33 551 389 309 309
query34 804 836 511 511
query35 801 803 717 717
query36 1059 1010 890 890
query37 116 104 82 82
query38 4234 4169 4090 4090
query39 1434 1400 1384 1384
query40 206 119 104 104
query41 56 53 53 53
query42 126 105 108 105
query43 500 508 463 463
query44 1319 781 774 774
query45 176 174 171 171
query46 838 1027 626 626
query47 1727 1779 1710 1710
query48 378 419 295 295
query49 780 501 465 465
query50 664 676 391 391
query51 4131 4130 3982 3982
query52 109 101 105 101
query53 234 249 183 183
query54 596 568 503 503
query55 85 78 77 77
query56 320 314 283 283
query57 1133 1146 1082 1082
query58 262 244 241 241
query59 2577 2721 2546 2546
query60 328 344 306 306
query61 127 121 123 121
query62 857 733 637 637
query63 222 183 184 183
query64 4426 1004 662 662
query65 4336 4253 4272 4253
query66 1147 420 315 315
query67 16010 15676 15418 15418
query68 7995 905 520 520
query69 473 297 262 262
query70 1181 1111 1091 1091
query71 453 328 303 303
query72 5509 4755 4966 4755
query73 739 688 343 343
query74 9163 9167 8817 8817
query75 3782 3202 2685 2685
query76 3641 1178 736 736
query77 795 391 282 282
query78 10183 10132 9216 9216
query79 2534 817 561 561
query80 602 509 452 452
query81 487 258 219 219
query82 457 127 93 93
query83 286 257 237 237
query84 301 107 87 87
query85 779 366 302 302
query86 385 319 258 258
query87 4386 4380 4288 4288
query88 3600 2204 2193 2193
query89 387 322 286 286
query90 1888 229 212 212
query91 142 133 110 110
query92 85 65 60 60
query93 1876 963 584 584
query94 671 427 307 307
query95 376 300 284 284
query96 486 561 277 277
query97 3140 3205 3145 3145
query98 242 214 207 207
query99 1436 1375 1240 1240
Total cold run time: 274880 ms
Total hot run time: 185051 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838480151
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2837955236
<details>
<summary>TPC-DS: <b>Total hot run time: 192045 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c059e1d5284189e5784b9493a1328200fe33d2df, data reload: false
query1 1404 1114 1074 1074
query2 6174 1755 1755 1755
query3 11177 4701 4452 4452
query4 54522 25946 23356 23356
query5 5130 516 456 456
query6 369 201 185 185
query7 4946 499 280 280
query8 316 261 241 241
query9 5908 2625 2648 2625
query10 429 325 279 279
query11 15044 15124 14936 14936
query12 159 118 113 113
query13 1071 534 398 398
query14 10231 6361 6400 6361
query15 210 207 183 183
query16 7076 690 512 512
query17 1080 748 608 608
query18 1568 417 359 359
query19 193 200 167 167
query20 122 123 123 123
query21 205 120 107 107
query22 4385 4369 4199 4199
query23 34048 33486 33591 33486
query24 6698 2363 2442 2363
query25 449 467 393 393
query26 721 280 156 156
query27 2304 513 336 336
query28 3111 2138 2123 2123
query29 604 567 437 437
query30 283 214 186 186
query31 895 857 819 819
query32 78 64 66 64
query33 437 370 300 300
query34 782 852 530 530
query35 821 847 754 754
query36 962 983 918 918
query37 104 101 82 82
query38 4259 4228 4177 4177
query39 1519 1411 1424 1411
query40 201 124 106 106
query41 55 54 52 52
query42 123 111 114 111
query43 527 509 448 448
query44 1290 833 830 830
query45 181 182 173 173
query46 866 1075 656 656
query47 1822 1873 1783 1783
query48 389 418 325 325
query49 688 505 405 405
query50 651 709 408 408
query51 4182 4172 4160 4160
query52 107 111 106 106
query53 241 274 190 190
query54 577 584 503 503
query55 88 79 83 79
query56 292 290 280 280
query57 1165 1177 1135 1135
query58 268 255 255 255
query59 2615 2710 2613 2613
query60 328 340 305 305
query61 127 123 124 123
query62 762 773 693 693
query63 242 206 199 199
query64 1817 1194 674 674
query65 4418 4222 4291 4222
query66 714 403 306 306
query67 15744 15513 15247 15247
query68 7080 885 519 519
query69 540 301 266 266
query70 1202 1175 1099 1099
query71 526 313 285 285
query72 5542 4755 4814 4755
query73 1376 607 343 343
query74 9060 8981 8609 8609
query75 3854 3184 2766 2766
query76 4306 1197 772 772
query77 615 385 293 293
query78 10116 10027 9321 9321
query79 2553 822 564 564
query80 610 504 432 432
query81 498 247 216 216
query82 438 128 97 97
query83 366 262 235 235
query84 292 111 82 82
query85 780 351 315 315
query86 373 305 281 281
query87 4406 4357 4253 4253
query88 3477 2198 2196 2196
query89 399 307 284 284
query90 1797 211 210 210
query91 140 139 109 109
query92 79 60 56 56
query93 2050 975 587 587
query94 658 409 312 312
query95 369 302 291 291
query96 475 563 269 269
query97 3185 3228 3056 3056
query98 228 256 201 201
query99 1431 1374 1280 1280
Total cold run time: 299095 ms
Total hot run time: 192045 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2837680406
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838438127
# BE Regression P0 && UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50535_c059e1d5284189e5784b9493a1328200fe33d2df_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50535_c059e1d5284189e5784b9493a1328200fe33d2df_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.47% (20767/26466) |
| Line Coverage | 71.89% (211879/294719) |
| Region Coverage | 70.07% (127284/181658) |
| Branch Coverage | 63.28% (64729/102288) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2859335186
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 closed pull request #50535: [enhancement](cloud) support param to drop fe cluster not in safe time
URL: https://github.com/apache/doris/pull/50535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 closed pull request #50535: [enhancement](cloud) support param to drop fe cluster not in safe time
URL: https://github.com/apache/doris/pull/50535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838094744
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2837700047
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2837826635
run cloud_ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2838982421
# BE Regression P0 && UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50535_c059e1d5284189e5784b9493a1328200fe33d2df_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50535_c059e1d5284189e5784b9493a1328200fe33d2df_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.29% (20720/26466) |
| Line Coverage | 71.75% (211455/294719) |
| Region Coverage | 69.90% (126976/181658) |
| Branch Coverage | 63.21% (64653/102288) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2857151135
# BE Regression && UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50535_66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50535_66aeb3ad4f3fc233a347fc1aae0a8eb08cce2c1a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.95% (21242/26241) |
| Line Coverage | 74.86% (219666/293424) |
| Region Coverage | 73.21% (132182/180564) |
| Branch Coverage | 66.59% (67549/101438) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2862859813
reopen at #50680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](cloud) support param to drop fe cluster not in safe time [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #50535:
URL: https://github.com/apache/doris/pull/50535#issuecomment-2859328100
run cloud_ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org