You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/14 11:58:10 UTC

[GitHub] [couchdb-nano] glynnbird opened a new pull request #201: ensure TypeScript definitions are sound during testing

glynnbird opened a new pull request #201: ensure TypeScript definitions are sound during testing
URL: https://github.com/apache/couchdb-nano/pull/201
 
 
   I noticed the TypeScript definitions weren't syntactically correct, so I fixed them and ensured that the `npm run test` command checks the TypeScript syntax too.
   
   ## Overview
   
   Fix TypeScript definition and ensure that the tests can't pass with invalid TypeScript definitions in the future.
   
   ## Testing recommendations
   
   npm run test
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-nano] glynnbird merged pull request #201: ensure TypeScript definitions are sound during testing

Posted by GitBox <gi...@apache.org>.

glynnbird merged pull request #201: ensure TypeScript definitions are sound during testing
URL: https://github.com/apache/couchdb-nano/pull/201
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services