You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/05 15:08:18 UTC
[GitHub] [pulsar] addisonj opened a new pull request #6203: [functions]
Default functionAuthProvider when running in k8s
addisonj opened a new pull request #6203: [functions] Default functionAuthProvider when running in k8s
URL: https://github.com/apache/pulsar/pull/6203
### Motivation
In 2.4.x, when running with the KubernetesRuntime, it default to always
using the KubernetesSecretAuthProvider class. With the change in 2.5 to
making this behavior pluggable, there is currently a bug in that it
doesn't keep this behavior and requires a new configuration option to be
passed.
### Modifications
This commit changes the config so that it defaults to the correct class
when we are running with a kubernetes runtime. This restores the
behavior match that of earlier versions
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- Added a test that ensures that we get the correct default based on other config values
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): n
- The public API: n
- The schema: n
- The default values of configurations: y
- The wire protocol:n
- The rest endpoints: n
- The admin cli options: n
- Anything that affects deployment: n
### Documentation
- Does this pull request introduce a new feature? n
- If yes, how is the feature documented? n/a
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services