You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by "zkaoudi (via GitHub)" <gi...@apache.org> on 2023/04/13 11:38:30 UTC
[GitHub] [incubator-wayang] zkaoudi opened a new issue, #283: Code restructure
zkaoudi opened a new issue, #283:
URL: https://github.com/apache/incubator-wayang/issues/283
Currently, there are some modules that the source code is not in the usual path of "[module_name]/src/main/java" but inside a "code" folder. This is not the case for all modules. We should restructure the code to be as it is done usually: "[module_name]/src/main/java"
NOTE: It seems that this "code" folder was created because of some incompatibility with GraphChi and the java/scala versions. So we may have to discard GraphChi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Code restructure [incubator-wayang]
Posted by "2pk03 (via GitHub)" <gi...@apache.org>.
2pk03 commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1840144862
bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Code restructure [incubator-wayang]
Posted by "juripetersen (via GitHub)" <gi...@apache.org>.
juripetersen commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1884301557
I will take care of implementing the restructure of this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Code restructure [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1840173392
What about retiring scala 2.11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Code restructure [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1884412712
Great! Thanks Juri!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] jimtds commented on issue #283: Code restructure
Posted by "jimtds (via GitHub)" <gi...@apache.org>.
jimtds commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1573305758
One reason the ../code/.. directories exist is to avoid multiple Scala versions deps within the same project. So If it is needed to support multiple versions, maybe a strategy like 1 branch/version would be a good idea to avoid code duplication due to deps with different versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] bgeng777 commented on issue #283: Code restructure
Posted by "bgeng777 (via GitHub)" <gi...@apache.org>.
bgeng777 commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1519088854
+1 for the restructure and retire GraphChi. If we want to take a further step after removing GraphChi, it is worthwhile to consider retiring Scala2.11 as well.
The underlying engines have done such removal:
Spark dropped Scala2.11 since Spark3.0. See [here](https://issues.apache.org/jira/browse/SPARK-26132)
Flink dropped Scala2.11 since Flink1.15. See [here](https://issues.apache.org/jira/browse/FLINK-20845)
It can reduce matainers' bandwidth on different scala version. Feel free to correct me if I may miss some potential dependency on Scala2.11 in Wayang. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] 2pk03 commented on issue #283: Code restructure
Posted by "2pk03 (via GitHub)" <gi...@apache.org>.
2pk03 commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1508264326
+1 to retire GraphChi, we also should considering to retire Java 8 support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] 2pk03 commented on issue #283: Code restructure
Posted by "2pk03 (via GitHub)" <gi...@apache.org>.
2pk03 commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1519089253
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Code restructure [incubator-wayang]
Posted by "kbeedkar (via GitHub)" <gi...@apache.org>.
kbeedkar commented on issue #283:
URL: https://github.com/apache/incubator-wayang/issues/283#issuecomment-1840196807
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org