You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by simonellistonball <gi...@git.apache.org> on 2017/08/30 00:53:36 UTC
[GitHub] metron pull request #722: METRON-1139 Fixed service advisor profilerHost var...
GitHub user simonellistonball opened a pull request:
https://github.com/apache/metron/pull/722
METRON-1139 Fixed service advisor profilerHost variable
## Contributor Comments
This is a simple variable mis-naming error which doesn't cause any immediate problems, but prevents the stack advisor running properly, which can prevent subsequent component installs.
To recreate, install a metron cluster, then attempt to install another component. The next button in the ambari wizard will remain disabled on master selection, and the request history will show a 500 error on the stack advisor step. This fix solves the problem.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simonellistonball/incubator-metron METRON-1139
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/722.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #722
----
commit 942c7a518463f117e77ba0111b65a40203db74f5
Author: Simon Elliston Ball <si...@simonellistonball.com>
Date: 2017-08-30T00:48:48Z
Fixed service advisor profilerHost variable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #722: METRON-1139 Fixed service advisor profilerHost variable
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/722
+1 by inspection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #722: METRON-1139 Fixed service advisor profilerHost var...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---