Re: [I] Bulk insert As Row: Should also repartiiton records if populateMetaFields is false [hudi]

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on issue #15268:
URL: https://github.com/apache/hudi/issues/15268#issuecomment-4795344025

   This appears to have been addressed by [HUDI-5351](https://issues.apache.org/jira/browse/HUDI-5351) / [PR #7411](https://github.com/apache/hudi/pull/7411) (commit `ae426bc4`). On current master:
   
   - `HoodieDatasetBulkInsertHelper.prepareForBulkInsert` unconditionally calls `partitioner.repartitionRecords(...)` for both `populateMetaFields=true` and `false` paths.
   - Row-based sort partitioners that semantically depend on `_hoodie_partition_path` / `_hoodie_record_key` (`GlobalSortPartitionerWithRows`, `PartitionSortPartitionerWithRows`, `PartitionPathRepartitionPartitionerWithRows`, `PartitionPathRepartitionAndSortPartitionerWithRows`) now fail fast with `HoodieException("<MODE> mode requires meta-fields to be enabled")` instead of silently producing un-repartitioned output.
   - `NonSortPartitionerWithRows` correctly coalesces without needing meta-fields.
   
   The originally-linked PR #6028 was never merged; HUDI-5351 superseded it. If you can still reproduce a missing-repartition scenario on a recent release, please share the exact `hoodie.bulkinsert.sort.mode` + populateMetaFields combo and a small repro — otherwise this can probably be closed as fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org