You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "JHoelli (via GitHub)" <gi...@apache.org> on 2026/08/10 13:42:22 UTC
[PR] 1381 cleanup duplicated testing logic
JHoelli opened a new pull request, #4821:
URL: https://github.com/apache/streampipes/pull/4821
Last adaption of code to new Workflow and Manage Dialog.
- replaced old Mange Permission Dialog with Manage Dialog in Datasets
- removed ManagePersmissionDialog
- fixed testing logic and removed duplicated testing logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 1381 cleanup duplicated testing logic
Posted by "JHoelli (via GitHub)" <gi...@apache.org>.
JHoelli commented on code in PR #4821:
URL: https://github.com/apache/streampipes/pull/4821#discussion_r3782210322
##########
ui/cypress/support/utils/user/PermissionUtils.ts:
##########
@@ -51,7 +40,7 @@ export class PermissionUtils {
public static changeOwnershipInManageDialog(email: string) {
cy.dataCy('owner-select').click();
cy.get(`[data-cy="owner-option-${email}"]`, { timeout: 10000 }).click();
Review Comment:
Unfortunately, no, due to the necessary timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 1381 cleanup duplicated testing logic
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #4821:
URL: https://github.com/apache/streampipes/pull/4821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 1381 cleanup duplicated testing logic
Posted by "JHoelli (via GitHub)" <gi...@apache.org>.
JHoelli commented on code in PR #4821:
URL: https://github.com/apache/streampipes/pull/4821#discussion_r3782210322
##########
ui/cypress/support/utils/user/PermissionUtils.ts:
##########
@@ -51,7 +40,7 @@ export class PermissionUtils {
public static changeOwnershipInManageDialog(email: string) {
cy.dataCy('owner-select').click();
cy.get(`[data-cy="owner-option-${email}"]`, { timeout: 10000 }).click();
Review Comment:
Unfortunately, no, due to the necessary timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 1381 cleanup duplicated testing logic
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on code in PR #4821:
URL: https://github.com/apache/streampipes/pull/4821#discussion_r3781798160
##########
ui/cypress/support/utils/user/PermissionUtils.ts:
##########
@@ -51,7 +40,7 @@ export class PermissionUtils {
public static changeOwnershipInManageDialog(email: string) {
cy.dataCy('owner-select').click();
cy.get(`[data-cy="owner-option-${email}"]`, { timeout: 10000 }).click();
Review Comment:
Can this be changed to a cy.dataCy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 1381 cleanup duplicated testing logic
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #4821:
URL: https://github.com/apache/streampipes/pull/4821#issuecomment-5290573252
Hi @JHoelli,
the PR looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org