You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/06/06 12:13:40 UTC

Review Request 59837: Added logging of flag warnings in the default executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59837/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Added logging of flag warnings in the default executor.


Diffs
-----

  src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 


Diff: https://reviews.apache.org/r/59837/diff/1/


Testing
-------

make check


Thanks,

Andrei Budnik


Re: Review Request 59837: Added logging of flag warnings in the default executor.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59837/#review177024
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On June 6, 2017, 12:13 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59837/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 12:13 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added logging of flag warnings in the default executor.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 
> 
> 
> Diff: https://reviews.apache.org/r/59837/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Re: Review Request 59837: Added logging of flag warnings in the default executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59837/#review177166
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On June 6, 2017, 2:33 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59837/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 2:33 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-6961
>     https://issues.apache.org/jira/browse/MESOS-6961
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 
> 
> 
> Diff: https://reviews.apache.org/r/59837/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Re: Review Request 59837: Added logging of flag warnings in the default executor.

Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59837/
-----------------------------------------------------------

(Updated June 6, 2017, 2:33 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-6961
    https://issues.apache.org/jira/browse/MESOS-6961


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 


Diff: https://reviews.apache.org/r/59837/diff/1/


Testing
-------

make check


Thanks,

Andrei Budnik


Re: Review Request 59837: Added logging of flag warnings in the default executor.

Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59837/
-----------------------------------------------------------

(Updated June 6, 2017, 1:44 p.m.)


Review request for mesos.


Repository: mesos


Description (updated)
-------

See summary.


Diffs
-----

  src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 


Diff: https://reviews.apache.org/r/59837/diff/1/


Testing
-------

make check


Thanks,

Andrei Budnik