[GitHub] [gobblin] umustafi commented on a diff in pull request #3695: [GOBBLIN-1832] Emit warning instead of failing job for retention of …

["umustafi (via GitHub)" <gi...@apache.org>]

umustafi commented on code in PR #3695:
URL: https://github.com/apache/gobblin/pull/3695#discussion_r1189276199


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/version/finder/AbstractHiveDatasetVersionFinder.java:
##########
@@ -56,8 +58,9 @@ public Class<? extends DatasetVersion> versionClass() {
    * Calls {@link #getDatasetVersion(Partition)} for every {@link Partition} found.
    * <p>
    * Note: If an exception occurs while processing a partition, that partition will be ignored in the returned collection
+   * Also note that if the dataset passed is a view type, we will return an empty list even if the underlying table is
+   * partitioned. 
    * </p>
-   *

Review Comment:
   i'll remove this 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org