You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bval.apache.org by mb...@apache.org on 2010/09/07 22:19:43 UTC

svn commit: r993518 - /incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheFactoryContext.java

Author: mbenson
Date: Tue Sep  7 20:19:43 2010
New Revision: 993518

URL: http://svn.apache.org/viewvc?rev=993518&view=rev
Log:
deprecate constructor that accepts a MetaBeanFinder; refactor internals such that a subclass can build any MetaBeanFinder rather than a MetaBeanManager only

Modified:
    incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheFactoryContext.java

Modified: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheFactoryContext.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheFactoryContext.java?rev=993518&r1=993517&r2=993518&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheFactoryContext.java (original)
+++ incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheFactoryContext.java Tue Sep  7 20:19:43 2010
@@ -46,7 +46,7 @@ public class ApacheFactoryContext implem
      */
     public ApacheFactoryContext(ApacheValidatorFactory factory) {
         this.factory = factory;
-        this.metaBeanFinder = buildMetaBeanManager();
+        this.metaBeanFinder = buildMetaBeanFinder();
     }
 
     /**
@@ -54,6 +54,9 @@ public class ApacheFactoryContext implem
      * 
      * @param factory
      * @param metaBeanFinder
+     * @deprecated does anyone need this?  If the default {@link ApacheFactoryContext}
+     * uses a {@link Jsr303MetaBeanFactory}, which circularly refers to its owning {@link ApacheFactoryContext},
+     * it follows that this constructor can't be conveniently used with a {@link Jsr303MetaBeanFactory}.
      */
     protected ApacheFactoryContext(ApacheValidatorFactory factory, MetaBeanFinder metaBeanFinder) {
         this.factory = factory;
@@ -150,7 +153,7 @@ public class ApacheFactoryContext implem
      * @return a new instance of MetaBeanManager with adequate MetaBeanFactories
      */
     @SuppressWarnings("deprecation")
-    protected MetaBeanManager buildMetaBeanManager() {
+    protected MetaBeanFinder buildMetaBeanFinder() {
         List<MetaBeanFactory> builders = new ArrayList<MetaBeanFactory>(2);
         if (Boolean.parseBoolean(factory.getProperties().get(
             ApacheValidatorConfiguration.Properties.ENABLE_INTROSPECTOR))) {