You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/08/03 01:43:00 UTC

[jira] [Commented] (HBASE-18303) Clean up some parameterized test declarations

    [ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112053#comment-16112053 ] 

stack commented on HBASE-18303:
-------------------------------

Skimmed. Looks good.

> Clean up some parameterized test declarations
> ---------------------------------------------
>
>                 Key: HBASE-18303
>                 URL: https://issues.apache.org/jira/browse/HBASE-18303
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18303.patch, HBASE-18303.patch
>
>
> While debugging something unrelated, I noticed that we use the constructor form of junit parameterized tests, instead of the annotated members form.
> I personally find using the @Parameter annotation more clear.
> Also, we can move the parameter generator to hbase-common so that it is accessible in more modules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)