[GitHub] [arrow] jonkeane commented on pull request #10373: ARROW-11849: [R] Use roxygen @examplesIf

[GitBox <gi...@apache.org>]

jonkeane commented on pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#issuecomment-849659359


   Yeah, I think this is fine to merge. One thing to note, that version number requirement might be satisfied but with a dev version that doesn't include the feature we're using (I haven't checked the git history, but I imagine there are commits after the last release, but before they added `examplesif`). Which would be annoying to diagnose, but with our comment about needing an up-to-date roxygen2, that should hopefully be enough.  I'll comment on the jira with thoughts about `DESCRIPTION` itself.
   
   Do we already have or do we need/want a CI job that checks if the docs can be built when these features aren't around — I assume that `examplesif` works just fine, but it would be good for us to check that we've not accidentally forgotten it / used the wrong test / etc. (this can of course also be a follow on)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org