[GitHub] [cordova-android] erisu commented on a change in pull request #699: Improve Gradle Build Arguments

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #699: Improve Gradle Build Arguments
URL: https://github.com/apache/cordova-android/pull/699#discussion_r270262386
 
 

 ##########
 File path: bin/templates/cordova/lib/build.js
 ##########
 @@ -266,6 +270,8 @@ module.exports.help = function () {
     console.log('    \'--prepenv\': don\'t build, but copy in build scripts where necessary');
     console.log('    \'--versionCode=#\': Override versionCode for this build. Useful for uploading multiple APKs.');
     console.log('    \'--minSdkVersion=#\': Override minSdkVersion for this build. Useful for uploading multiple APKs.');
+    console.log('    \'--maxSdkVersion=#\': Override maxSdkVersion for this build. Useful for uploading multiple APKs.');
 
 Review comment:
   At best, we might only be able to add to the printout `(Not Recommended)`.
   
   We already supported the setting of the `maxSdkVersion` property through `config.xml` and in which sets it in `AndroidManifest.xml`.
   
   This PR moves the `maxSdkVersion` definition into the Gradle's workflow and removes from `AndroidManifest.xml`. 
   
   This does add a new command line option to exposes alternative ways for defining this value other than `config.xml`. I thought it was a missed option because we supported `min` and believe there was no harm to add.
   
   If we want to remove `maxSdkVersion` altogether, it then becomes a `major` change. As for future planning, it would be best if I dont add the new command-line option then and then add warnings that the `maxSdkVersion` setting will be deprecated in next major.
   
   Thoughts and Opinions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org