You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2017/02/15 02:28:45 UTC
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 2:28 a.m.)
Review request for atlas.
Summary (updated)
-----------------
Fix DeleteHandlerV1 for new model changes and add tests
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs
-----
addons/models/0030-hive_model.json 33ba156
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165870
-----------------------------------------------------------
Ship it!
Ship It!
- David Kantor
On Feb. 16, 2017, 6:55 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 6:55 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4d11b20
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 987951e
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf73174
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Added tests for hard delete and soft delete
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 6:55 a.m.)
Review request for atlas.
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4d11b20
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 987951e
server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf73174
Diff: https://reviews.apache.org/r/56535/diff/
Testing (updated)
-------
Added tests for hard delete and soft delete
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 6:54 a.m.)
Review request for atlas.
Changes
-------
Fixed review comments and added tests for Hard Delete
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4d11b20
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 987951e
server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf73174
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad