[jira] [Commented] (GEODE-8647) Support using multiple DistributedMap Rules in one test

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225419#comment-17225419 ] 

ASF GitHub Bot commented on GEODE-8647:
---------------------------------------

pivotal-jbarrett commented on a change in pull request #682:
URL: https://github.com/apache/geode-native/pull/682#discussion_r516176141



##########
File path: clicache/src/DataInput.cpp
##########
@@ -878,8 +877,6 @@ namespace Apache
 
       void DataInput::Cleanup()
       {

Review comment:
       If this method is empty perhaps we can remove it?

##########
File path: clicache/src/DataInput.hpp
##########
@@ -663,7 +664,7 @@ namespace Apache
           m_buffer = const_cast<System::Byte*>(nativeptr->currentBufferPosition());
           if ( m_buffer != NULL) {
             m_bufferLength = static_cast<decltype(m_bufferLength)>(nativeptr->getBytesRemaining());
-					}
+          }

Review comment:
       Some strange formatting mess here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support using multiple DistributedMap Rules in one test
> -------------------------------------------------------
>
>                 Key: GEODE-8647
>                 URL: https://issues.apache.org/jira/browse/GEODE-8647
>             Project: Geode
>          Issue Type: Wish
>          Components: tests
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: pull-request-available
>
> Support using multiple DistributedMap Rules in one test. Right now the Rule only supports having one instance in a test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)