[GitHub] [couchdb] davisp commented on issue #2077: Make sure that fsync errors are raised

[GitBox <gi...@apache.org>]

davisp commented on issue #2077: Make sure that fsync errors are raised
URL: https://github.com/apache/couchdb/pull/2077#issuecomment-513801708
 
 
   I’m not against it but given the already sneaky bits of fsync I hesitated
   to do too much in a single PR.
   
   On Mon, Jul 22, 2019 at 3:27 AM Jan Lehnardt <no...@github.com>
   wrote:
   
   > *@janl* commented on this pull request.
   > ------------------------------
   >
   > In src/couch/src/couch_file.erl
   > <https://github.com/apache/couchdb/pull/2077#discussion_r305725638>:
   >
   > > @@ -215,12 +215,26 @@ truncate(Fd, Pos) ->
   >  sync(Filepath) when is_list(Filepath) ->
   >      case file:open(Filepath, [append, raw]) of
   >
   > 21:50:18] <+davisp> The first version of couch_file:sync that takes a file
   > path isn't called anymore. That was a remnant from when couch_db_updater
   > had two couch_file processes
   >
   > Why not remove this then?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/couchdb/pull/2077?email_source=notifications&email_token=AAAE3WMDTFCGTC3N2LXVYNDQAVVODA5CNFSM4IFTJGNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7DHMOA#pullrequestreview-264664632>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAE3WIGDYQQPMX665WZQ7DQAVVODANCNFSM4IFTJGNA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services