You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/10/08 13:06:34 UTC

[GitHub] [buildstream] nanonyme commented on a diff in pull request #1768: sandbox: add dummy sandbox for checking out artifacts from different arches

nanonyme commented on code in PR #1768:
URL: https://github.com/apache/buildstream/pull/1768#discussion_r990640145


##########
buildstream/_platform/linux.py:
##########
@@ -22,13 +22,21 @@
 
 from .. import _site
 from .. import utils
-from ..sandbox import SandboxBwrap
+from ..sandbox import SandboxBwrap, SandboxDummy
 
 from . import Platform
 
 
 class Linux(Platform):
 
+    ARCHITECTURES = {

Review Comment:
   I know it was called like this before so it's not really a change but not entirely obvious from name that this is just an alias mapping and unlisted things may be supported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org